fix: remove impossible case #4303
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes an impossible case from the SetMode function's switch statement. The change eliminates the handling of an empty string ("") case since the PR description indicates that null values are now guaranteed to be set to either test or debug beforehand.
- Simplified the switch statement by removing the empty string case from the
DebugModecondition
| value = DebugMode | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Consider adding input validation or documentation to ensure that empty string values are indeed impossible. If this assumption changes in the future, removing this case could introduce bugs where empty strings fall through to an unhandled case.
| if !isValidMode(value) { | |
| panic("gin mode unknown: " + value + " (available modes: debug, release, test)") | |
| } |
Copilot uses AI. Check for mistakes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4303 +/- ##
==========================================
- Coverage 99.21% 98.92% -0.30%
==========================================
Files 42 44 +2
Lines 3182 3437 +255
==========================================
+ Hits 3157 3400 +243
- Misses 17 26 +9
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If
valueis null, it will be set totestordebugso it doesn't need to catch "" case anymore.