Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint transition: update code so "@typescript-eslint/restrict-template-expressions" passes #196

Open
cbraynor opened this issue Sep 14, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@cbraynor
Copy link
Contributor

This issue relates to the @typescript-eslint/restrict-template-expressions rule.

During the transition from TSLint (now deprecated) to ESLint for typescript linting we introduced some new rules that don't yet pass and added a temporary override in the .eslintrc.json file to temporarily disable them.

This issue covers removing that temporary override and any changes to the typescript code required to get the rule passing. Use npm run lint to run the linter and once you've done changing the typescript don't forget to also run npm run build to reflect the changes in the built javascript (which also needs to be checked in).

@cbraynor cbraynor added the good first issue Good for newcomers label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant