Skip to content

Update hook_id to int64 #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Update hook_id to int64 #1838

merged 1 commit into from
Mar 31, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Mar 31, 2021

Fixes: #1837.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Mar 31, 2021
@gmlewis
Copy link
Collaborator Author

gmlewis commented Mar 31, 2021

@lindluni - PTAL.

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1838 (f15cb6e) into master (3130b78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1838   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         104      104           
  Lines        6602     6602           
=======================================
  Hits         6441     6441           
  Misses         87       87           
  Partials       74       74
Impacted Files Coverage Δ
github/orgs_audit_log.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3130b78...f15cb6e. Read the comment docs.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Mar 31, 2021
@lindluni
Copy link
Contributor

@lindluni - PTAL.

Thank you @gmlewis LGTM. Our CLA contact is out of the office today. Appreciate the help getting this in.

@gmlewis gmlewis merged commit 859ff4c into google:master Mar 31, 2021
@gmlewis gmlewis deleted the i-1837-hook-id-int64 branch March 31, 2021 21:15
@gmlewis gmlewis mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmlewis @lindluni