Skip to content

Support map type in go generate #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

Support map type in go generate #1867

merged 2 commits into from
May 7, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented May 7, 2021

Fixes: #1866.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #1867 (9b05852) into master (85c1b28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         105      105           
  Lines        6769     6771    +2     
=======================================
+ Hits         6610     6612    +2     
  Misses         86       86           
  Partials       73       73
Impacted Files Coverage Δ
github/strings.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c1b28...9b05852. Read the comment docs.

@gmlewis gmlewis requested a review from wesleimp May 7, 2021 00:56
wesleimp
wesleimp approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator Author

gmlewis commented May 7, 2021

Thank you, @wesleimp !
Merging.

@gmlewis gmlewis merged commit a19996a into google:master May 7, 2021
@gmlewis gmlewis deleted the i1866-support-map-go-generate branch May 7, 2021 13:33
@olibaa olibaa mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wesleimp wesleimp wesleimp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go generate broken when adding map[string]bool
2 participants
@gmlewis @wesleimp