Add allows_public_repositories to actions_runner_group #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds allows_public_repositories to request bodies of the CreateRunnerGroup as well as UpdateRunnerGroup methods for github actions. This allows us to set the allows_public_repositories flag even if it is not yet properly documented see https://github.com/github/docs/issues/8209 That flag controls if public repos can use runners of this group. If it is disabled(default) even public repos that are added to the selected_repositories list cannot use runners of this group. With this change we can now set this properly and thus use runner groups created by go-github also for public repos. Fixes google#1996
|
I mirrored the style from the existing structs to do pass by reference so having a bool pointer. |
gmlewis
requested changes
Jul 14, 2021
There was a problem hiding this comment.
Thank you, @FloThinksPi !
Please run go generate ./... and push (not force-push) the changes to this PR, as described in our CONTRIBUTING.md document.
gmlewis
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds allows_public_repositories to request bodies of the
CreateRunnerGroup as well as UpdateRunnerGroup methods for github
actions.
This allows us to set the allows_public_repositories flag even if it is
not yet properly documented see https://github.com/github/docs/issues/8209
That flag controls if public repos can use runners of this group.
If it is disabled(default) even public repos that are added to the
selected_repositories list cannot use runners of this group.
With this change we can now set this properly and thus use runner groups
created by go-github also for public repos.
Fixes #1996