Skip to content

Make test names consistent #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Make test names consistent #2002

merged 1 commit into from
Jul 16, 2021

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jul 15, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 15, 2021
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 15, 2021

@sagar23sj - would you mind giving me an LGTM+Approval on this one if you agree, please?

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2002 (ef66b92) into master (c478f27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2002   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         107      107           
  Lines        6897     6897           
=======================================
  Hits         6750     6750           
  Misses         81       81           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c478f27...ef66b92. Read the comment docs.

@sagar23sj
Copy link
Contributor

Sure @gmlewis
LGTM.

@sagar23sj
Copy link
Contributor

sagar23sj commented Jul 16, 2021 •
edited
Loading

There are few files remaining @gmlewis. I have listed them below

  • licenses_test.go
  • orgs_test.go
  • pulls_reviewers_test.go

@gmlewis gmlewis merged commit 34be973 into google:master Jul 16, 2021
@gmlewis gmlewis deleted the fix-typos branch July 16, 2021 11:08
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 16, 2021

Sure, @sagar23sj ... Thank you!

@sagar23sj
Copy link
Contributor

If it's ok with you and you have'nt already started working, i can raise PR for the remaining ones @gmlewis

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 16, 2021

If it's ok with you and you have'nt already started working, i can raise PR for the remaining ones @gmlewis

Perfect... thank you, @sagar23sj !

@gmlewis gmlewis mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sagar23sj sagar23sj sagar23sj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmlewis @sagar23sj