Skip to content

Fix deprecated field #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2021
Merged

Fix deprecated field #2017

merged 4 commits into from
Aug 6, 2021

Conversation

ganeshkumarsv
Copy link
Contributor

The deprecated field open got changed to state to hold 3 different values (open, dismissed, and fixed)

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #2017 (4afeb34) into master (b8294c3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2017   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         107      107           
  Lines        6897     6901    +4     
=======================================
+ Hits         6750     6754    +4     
  Misses         81       81           
  Partials       66       66
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <ø> (ø)
github/repos_statuses.go 100.00% <0.00%> (ø)
github/github.go 97.10% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8294c3...4afeb34. Read the comment docs.

@gmlewis gmlewis changed the title fix derecated field Fix derecated field Jul 21, 2021
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jul 21, 2021
gmlewis
gmlewis approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.

Awaiting second LGTM due to breaking API change.

@gmlewis gmlewis requested a review from wesleimp July 21, 2021 13:16
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis @wesleimp Gentle bump

@gmlewis gmlewis changed the title Fix derecated field Fix deprecated field Jul 26, 2021
gmlewis
gmlewis requested changes Jul 30, 2021
View reviewed changes
@ganeshkumarsv ganeshkumarsv requested a review from gmlewis July 30, 2021 17:58
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis @wesleimp gentle bump

Parker77
Parker77 approved these changes Aug 6, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit 816c8c6 into google:master Aug 6, 2021
@ganeshkumarsv
Copy link
Contributor Author

@gmlewis Thank you for approving & merging the PR. Can I know when the next release will be created for go-github?

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 10, 2021

@gmlewis Thank you for approving & merging the PR. Can I know when the next release will be created for go-github?

No problem. I should be able to cut a new release by tomorrow.

@ganeshkumarsv
Copy link
Contributor Author

awesome! Thank you!

@gmlewis gmlewis mentioned this pull request Aug 11, 2021
Merged
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 11, 2021

@ganeshkumarsv - v38 has now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshkumarsv @gmlewis @Parker77