Skip to content

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jul 27, 2025

Fixes: #3652.

This PR enhances DependencyGraphSnapshotManifest and DependencyGraphSnapshotResolvedDependency structs with Metadata property, following GitHub documentation.
This property enables to provide user-defined metadata to store domain-specific information limited to 8 keys with scalar values.

…cy and DependencyGraphSnapshotManifest + test enhancement
Copy link

google-cla bot commented Jul 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@6dda213). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3653   +/-   ##
=========================================
  Coverage          ?   91.25%           
=========================================
  Files             ?      184           
  Lines             ?    16311           
  Branches          ?        0           
=========================================
  Hits              ?    14884           
  Misses            ?     1245           
  Partials          ?      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title Add the Metadata property to create DependencyGraphSnapshotManifest & DependencyGraphSnapshotResolvedDependency Add Metadata to DependencyGraph* structs Jul 27, 2025
@gmlewis gmlewis changed the title Add Metadata to DependencyGraph* structs Add Metadata field to DependencyGraph* structs Jul 27, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @eranturgeman!
LGTM.
Merging.

@gmlewis gmlewis merged commit ac631dc into google:master Jul 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Metadata properties to DependencySubmission API structs (DependencyGraph.CreateSnapshot)
2 participants