-
Notifications
You must be signed in to change notification settings - Fork 422
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Pull request #15543 fixed build failures in several benchmark targets on the macOS Bazel CI. The builds were failing because they were missing a direct dependency on @com_google_benchmark//:benchmark
, even though they already depended on @com_google_benchmark//:benchmark_main
.
While adding the explicit dependency resolves the build errors, it's not clear why this is necessary. According to the google/benchmark
BUILD.bazel file, the :benchmark_main
target depends on :benchmark
and should export the necessary headers and symbols.
This issue affects the macOS Bazel CI builds.
This issue is to track the investigation into the root cause of this behavior:
- Why is a direct dependency on
@com_google_benchmark//:benchmark
required when a dependency on@com_google_benchmark//:benchmark_main
already exists? - Why does this issue appear to be specific to the macOS Bazel CI build environment?
- Is there a more fundamental issue in how dependencies are being resolved or in the toolchain configuration?
Acceptance Criteria:
- Understand and document the reason for the seemingly redundant dependency.
- Determine if a configuration change can remove the need for the explicit dependency on
@com_google_benchmark//:benchmark
in the benchmark targets.
Reference:
- PR fix(bazel): Add missing dependency to benchmark targets #15543: fix(bazel): Add missing dependency to benchmark targets
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.