Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-bigtable
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.2.0
Choose a base ref
...
head repository: googleapis/nodejs-bigtable
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.3.0
Choose a head ref
  • 9 commits
  • 30 files changed
  • 3 contributors

Commits on Jul 28, 2025

  1. feat: Client side metrics support for mutateRows (#1638)

    * Add metrics collector hooks in the right places
    
    * Move readrows tests over
    
    * Group ReadRows under separate describe block
    
    * Add mutateRows tests
    
    * Add onResponse to mutateRows collection
    
    * Eliminate the extra mutateRows calls
    
    * Change the test frame to work without inserting
    
    * Remove console traces
    
    * Remove the error console log
    
    * Inserts will conflate results for readRows too
    
    * Remove only
    
    * Remove only
    
    * Remove the extra onResponse call
    
    * Include onOperationComplete in the callback
    
    * Remove the onOperationComplete call
    
    * Get rid of error code fragment
    
    * onResponse handler moved into metrics collector
    
    * Rename handleStatusAndMetadata
    
    * Add comments, shorten snippet
    
    * Add the wrapRequest method to the mock
    
    * Pass null along instead
    
    * Add retries comment
    
    * Use the same setup table code as before
    
    * Rename method to setupBigtableWithInsert
    
    * Keep setupBigtable name as setupBigtable
    
    * Eliminate unused import
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * Run the linter
    
    * Make sure the table is set up properly, but don’t
    
    add a mutateRow call for the handlers tests
    
    * Remove only
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    danieljbruce and gcf-owl-bot[bot] authored Jul 28, 2025
    Configuration menu
    Copy the full SHA
    7601e4d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2025

  1. feat: Record ReadRows application latencies for client side metrics (#…

    …1647)
    
    ## Description
    
    This PR makes it so that all readRows calls will start recording application latencies. With this change, data for application latencies will now be available on the Google Cloud dashboard.
    
    ## Impact
    
    Data should now be available for application latencies on ReadRows calls in the client side metrics dashboard.
    
    ## Testing
    
    Tests are added that mock out the hrtime module and make sure the right application latencies values are recorded.
    danieljbruce authored Jul 29, 2025
    Configuration menu
    Copy the full SHA
    8af801b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2025

  1. feat: For client side metrics, record metrics as MUTATE_ROW for singl…

    …e row mutates (#1650)
    
    * Remove unused import
    
    * Move mutateInternal into an internal method
    
    * Eliminate unused dependencies
    
    * Adjust mocks so tests pass
    
    * Fix mocks to mock out mutate internal
    
    * Add mutateRow test suite 1
    
    * Add handler tests for MutateRow
    
    * Add header
    danieljbruce authored Aug 1, 2025
    Configuration menu
    Copy the full SHA
    f190a8c View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2025

  1. fix: firstResponseLatencies should only be collected for readRows cal…

    …ls (#1658)
    
    ## Description
    
    This fix ensures that first response latencies are only collected for ReadRows calls and not for the other grpc methods. This matches the requirements described in https://cloud.google.com/bigtable/docs/client-side-metrics-descriptions#first-response-latencies.
    
    ## Impact
    
    Ensures that the right client side metrics are getting collected for the right methods.
    
    ## Testing
    
    - More tolerance has been added to application latencies
    - We change the test to expect first response latencies for readRows calls and not expect them otherwise
    danieljbruce authored Aug 5, 2025
    Configuration menu
    Copy the full SHA
    99cf5a6 View commit details
    Browse the repository at this point in the history
  2. feat: Add client side metrics for readModifyWriteRow calls (#1656)

    ## Description
    
    This PR collects client side metrics for readModifyWriteRow calls and collects all the right types of metrics for these unary calls. They leverage the plumbing provided for unary calls to add interceptors to those calls so that we can record metrics for the right zone/cluster/server time.
    
    ## Impact
    
    This PR collects client side metrics for readModifyWriteRow calls.
    
    ## Testing
    
    For each readRows/mutateRows/mutateRow test we add a corresponding test for readModifyWriteRow.
    danieljbruce authored Aug 5, 2025
    Configuration menu
    Copy the full SHA
    2129312 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2025

  1. test: Generate a unique id for each of the instances in the client si…

    …de metrics system tests (#1662)
    
    * Move constant scope out
    
    eliminate magic string matching
    
    * Random ids for instances
    
    * Ensure proper setup and cleanup for second project
    
    * Remove only handlers
    danieljbruce authored Aug 6, 2025
    Configuration menu
    Copy the full SHA
    ce1e796 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2025

  1. feat: Collect client side metrics for sampleRowKeys calls (#1660)

    ## Description
    
    This PR makes it so that when sampleRowKeys calls are made that metrics will be collected for those calls and available to view in the Google Cloud Monitoring dashboard.
    
    ## Impact
    
    Now we collect client side metrics for sample row keys so that users can gain insights about what happens when a sampleRowKeys call gets made.
    
    ## Testing
    
    For all client side metrics tests that exist for ReadRows/MutateRows calls, a test will be added for sample row keys calls.
    danieljbruce authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    6ed98fa View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2025

  1. feat: Add client side metrics for checkAndMutateRow calls (#1661)

    ## Description
    
    This PR collects client side metrics for checkAndMutateRow calls and collects all the right types of metrics for these unary calls. They leverage the plumbing provided for unary calls to add interceptors to those calls so that we can record metrics for the right zone/cluster/server time.
    
    ## Impact
    
    This PR collects client side metrics for checkAndMutateRow calls.
    
    ## Testing
    
    For each readRows/mutateRows/mutateRow test we add a corresponding test for checkAndMutateRow.
    danieljbruce authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    c258ea1 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 6.3.0 (#1648)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [6.3.0](https://togithub.com/googleapis/nodejs-bigtable/compare/v6.2.0...v6.3.0) (2025-08-11)
    
    
    ### Features
    
    * Add client side metrics for checkAndMutateRow calls ([#1661](https://togithub.com/googleapis/nodejs-bigtable/issues/1661)) ([c258ea1](https://togithub.com/googleapis/nodejs-bigtable/commit/c258ea1b29203aad3eaaf9cfe64ddabb8c1018bf))
    * Add client side metrics for readModifyWriteRow calls ([#1656](https://togithub.com/googleapis/nodejs-bigtable/issues/1656)) ([2129312](https://togithub.com/googleapis/nodejs-bigtable/commit/2129312401bf9f5b8e51b13ac576cb765de401df))
    * Client side metrics support for mutateRows ([#1638](https://togithub.com/googleapis/nodejs-bigtable/issues/1638)) ([7601e4d](https://togithub.com/googleapis/nodejs-bigtable/commit/7601e4da115ff6a5da411cc857917b579c70ced7))
    * Collect client side metrics for sampleRowKeys calls ([#1660](https://togithub.com/googleapis/nodejs-bigtable/issues/1660)) ([6ed98fa](https://togithub.com/googleapis/nodejs-bigtable/commit/6ed98faefe446e67f83fd5394aae30374fd3ec3a))
    * For client side metrics, record metrics as MUTATE_ROW for single row mutates ([#1650](https://togithub.com/googleapis/nodejs-bigtable/issues/1650)) ([f190a8c](https://togithub.com/googleapis/nodejs-bigtable/commit/f190a8c322498ddfbe73406759a43a268c16bdc4))
    * Record ReadRows application latencies for client side metrics ([#1647](https://togithub.com/googleapis/nodejs-bigtable/issues/1647)) ([8af801b](https://togithub.com/googleapis/nodejs-bigtable/commit/8af801b3ecd7ff5e30e6c8cc67bd4123bdf34ee9))
    
    
    ### Bug Fixes
    
    * FirstResponseLatencies should only be collected for readRows calls ([#1658](https://togithub.com/googleapis/nodejs-bigtable/issues/1658)) ([99cf5a6](https://togithub.com/googleapis/nodejs-bigtable/commit/99cf5a6010249ed0eedd88f23b2d32cacb106c07))
    
    ---
    This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
    release-please[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    8e52277 View commit details
    Browse the repository at this point in the history
Loading