-
Notifications
You must be signed in to change notification settings - Fork 62
Comparing changes
Open a pull request
base repository: googleapis/nodejs-bigtable
base: v6.2.0
head repository: googleapis/nodejs-bigtable
compare: v6.3.0
- 9 commits
- 30 files changed
- 3 contributors
Commits on Jul 28, 2025
-
feat: Client side metrics support for mutateRows (#1638)
* Add metrics collector hooks in the right places * Move readrows tests over * Group ReadRows under separate describe block * Add mutateRows tests * Add onResponse to mutateRows collection * Eliminate the extra mutateRows calls * Change the test frame to work without inserting * Remove console traces * Remove the error console log * Inserts will conflate results for readRows too * Remove only * Remove only * Remove the extra onResponse call * Include onOperationComplete in the callback * Remove the onOperationComplete call * Get rid of error code fragment * onResponse handler moved into metrics collector * Rename handleStatusAndMetadata * Add comments, shorten snippet * Add the wrapRequest method to the mock * Pass null along instead * Add retries comment * Use the same setup table code as before * Rename method to setupBigtableWithInsert * Keep setupBigtable name as setupBigtable * Eliminate unused import * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Run the linter * Make sure the table is set up properly, but don’t add a mutateRow call for the handlers tests * Remove only --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7601e4d - Browse repository at this point
Copy the full SHA 7601e4dView commit details
Commits on Jul 29, 2025
-
feat: Record ReadRows application latencies for client side metrics (#…
…1647) ## Description This PR makes it so that all readRows calls will start recording application latencies. With this change, data for application latencies will now be available on the Google Cloud dashboard. ## Impact Data should now be available for application latencies on ReadRows calls in the client side metrics dashboard. ## Testing Tests are added that mock out the hrtime module and make sure the right application latencies values are recorded.
Configuration menu - View commit details
-
Copy full SHA for 8af801b - Browse repository at this point
Copy the full SHA 8af801bView commit details
Commits on Aug 1, 2025
-
feat: For client side metrics, record metrics as MUTATE_ROW for singl…
…e row mutates (#1650) * Remove unused import * Move mutateInternal into an internal method * Eliminate unused dependencies * Adjust mocks so tests pass * Fix mocks to mock out mutate internal * Add mutateRow test suite 1 * Add handler tests for MutateRow * Add header
Configuration menu - View commit details
-
Copy full SHA for f190a8c - Browse repository at this point
Copy the full SHA f190a8cView commit details
Commits on Aug 5, 2025
-
fix: firstResponseLatencies should only be collected for readRows cal…
…ls (#1658) ## Description This fix ensures that first response latencies are only collected for ReadRows calls and not for the other grpc methods. This matches the requirements described in https://cloud.google.com/bigtable/docs/client-side-metrics-descriptions#first-response-latencies. ## Impact Ensures that the right client side metrics are getting collected for the right methods. ## Testing - More tolerance has been added to application latencies - We change the test to expect first response latencies for readRows calls and not expect them otherwise
Configuration menu - View commit details
-
Copy full SHA for 99cf5a6 - Browse repository at this point
Copy the full SHA 99cf5a6View commit details -
feat: Add client side metrics for readModifyWriteRow calls (#1656)
## Description This PR collects client side metrics for readModifyWriteRow calls and collects all the right types of metrics for these unary calls. They leverage the plumbing provided for unary calls to add interceptors to those calls so that we can record metrics for the right zone/cluster/server time. ## Impact This PR collects client side metrics for readModifyWriteRow calls. ## Testing For each readRows/mutateRows/mutateRow test we add a corresponding test for readModifyWriteRow.
Configuration menu - View commit details
-
Copy full SHA for 2129312 - Browse repository at this point
Copy the full SHA 2129312View commit details
Commits on Aug 6, 2025
-
test: Generate a unique id for each of the instances in the client si…
…de metrics system tests (#1662) * Move constant scope out eliminate magic string matching * Random ids for instances * Ensure proper setup and cleanup for second project * Remove only handlers
Configuration menu - View commit details
-
Copy full SHA for ce1e796 - Browse repository at this point
Copy the full SHA ce1e796View commit details
Commits on Aug 7, 2025
-
feat: Collect client side metrics for sampleRowKeys calls (#1660)
## Description This PR makes it so that when sampleRowKeys calls are made that metrics will be collected for those calls and available to view in the Google Cloud Monitoring dashboard. ## Impact Now we collect client side metrics for sample row keys so that users can gain insights about what happens when a sampleRowKeys call gets made. ## Testing For all client side metrics tests that exist for ReadRows/MutateRows calls, a test will be added for sample row keys calls.
Configuration menu - View commit details
-
Copy full SHA for 6ed98fa - Browse repository at this point
Copy the full SHA 6ed98faView commit details
Commits on Aug 11, 2025
-
feat: Add client side metrics for checkAndMutateRow calls (#1661)
## Description This PR collects client side metrics for checkAndMutateRow calls and collects all the right types of metrics for these unary calls. They leverage the plumbing provided for unary calls to add interceptors to those calls so that we can record metrics for the right zone/cluster/server time. ## Impact This PR collects client side metrics for checkAndMutateRow calls. ## Testing For each readRows/mutateRows/mutateRow test we add a corresponding test for checkAndMutateRow.
Configuration menu - View commit details
-
Copy full SHA for c258ea1 - Browse repository at this point
Copy the full SHA c258ea1View commit details -
chore(main): release 6.3.0 (#1648)
🤖 I have created a release *beep* *boop* --- ## [6.3.0](https://togithub.com/googleapis/nodejs-bigtable/compare/v6.2.0...v6.3.0) (2025-08-11) ### Features * Add client side metrics for checkAndMutateRow calls ([#1661](https://togithub.com/googleapis/nodejs-bigtable/issues/1661)) ([c258ea1](https://togithub.com/googleapis/nodejs-bigtable/commit/c258ea1b29203aad3eaaf9cfe64ddabb8c1018bf)) * Add client side metrics for readModifyWriteRow calls ([#1656](https://togithub.com/googleapis/nodejs-bigtable/issues/1656)) ([2129312](https://togithub.com/googleapis/nodejs-bigtable/commit/2129312401bf9f5b8e51b13ac576cb765de401df)) * Client side metrics support for mutateRows ([#1638](https://togithub.com/googleapis/nodejs-bigtable/issues/1638)) ([7601e4d](https://togithub.com/googleapis/nodejs-bigtable/commit/7601e4da115ff6a5da411cc857917b579c70ced7)) * Collect client side metrics for sampleRowKeys calls ([#1660](https://togithub.com/googleapis/nodejs-bigtable/issues/1660)) ([6ed98fa](https://togithub.com/googleapis/nodejs-bigtable/commit/6ed98faefe446e67f83fd5394aae30374fd3ec3a)) * For client side metrics, record metrics as MUTATE_ROW for single row mutates ([#1650](https://togithub.com/googleapis/nodejs-bigtable/issues/1650)) ([f190a8c](https://togithub.com/googleapis/nodejs-bigtable/commit/f190a8c322498ddfbe73406759a43a268c16bdc4)) * Record ReadRows application latencies for client side metrics ([#1647](https://togithub.com/googleapis/nodejs-bigtable/issues/1647)) ([8af801b](https://togithub.com/googleapis/nodejs-bigtable/commit/8af801b3ecd7ff5e30e6c8cc67bd4123bdf34ee9)) ### Bug Fixes * FirstResponseLatencies should only be collected for readRows calls ([#1658](https://togithub.com/googleapis/nodejs-bigtable/issues/1658)) ([99cf5a6](https://togithub.com/googleapis/nodejs-bigtable/commit/99cf5a6010249ed0eedd88f23b2d32cacb106c07)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Configuration menu - View commit details
-
Copy full SHA for 8e52277 - Browse repository at this point
Copy the full SHA 8e52277View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v6.2.0...v6.3.0