-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterimpl: update picker synchronously upon receipt of configuration update #7210
Comments
@easwars I'd be working on this issue. |
14 tasks
After some thought, I've come to the understanding that I don't necessarily like the approach taken in the PR linked above because it still causes multiple picker updates and testing is very tied to the implementation rather than behavior. Instead I suggest we take the following approach. We can do this step-by-step:
|
This was referenced Aug 28, 2024
Merged
purnesh42H
added
the
Area: xDS
Includes everything xDS related, including LB policies used with xDS.
label
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#5469 recommends an audit of existing LB policies to ensure that they update their pickers synchronously upon receipt of a configuration update.
xds_cluster_impl_experimental
does not update its picker synchronously.grpc-go/xds/internal/balancer/clusterimpl/clusterimpl.go
Line 208 in 0561c78
grpc-go/xds/internal/balancer/clusterimpl/clusterimpl.go
Line 253 in 0561c78
UpdateClientConnState
grpc-go/xds/internal/balancer/clusterimpl/clusterimpl.go
Line 475 in 0561c78
grpc-go/xds/internal/balancer/clusterimpl/clusterimpl.go
Line 479 in 0561c78
This needs to be changed to return a picker synchronously upon receipt of a configuration update.
The text was updated successfully, but these errors were encountered: