Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: worker concurrency not documented correctly (Typescript) #743

Open
semse opened this issue Jul 25, 2024 · 3 comments
Open

docs: worker concurrency not documented correctly (Typescript) #743

semse opened this issue Jul 25, 2024 · 3 comments

Comments

@semse
Copy link

semse commented Jul 25, 2024

Documented is:

const worker = hatchet.worker("my-worker", {
maxRuns: 5,
});

But instead it should be:

const worker = hatchet.worker("my-worker", 5);

The documented code does not work and leads to an error.

https://docs.hatchet.run/home/features/concurrency/overview
@heysolomon
Copy link

I would like to work on this @mavenraven

@mavenraven
Copy link
Contributor

Hey @heysolomon, @abelanger5 and @grutt are better points of contact.

@grutt
Copy link
Contributor

grutt commented Jul 29, 2024

Thanks for the ping @mavenraven

@semse this change was introduced in hatchet-dev/hatchet-typescript#213 in favor of options, but the change should be backwards compatible with your existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mavenraven @semse @grutt @heysolomon