Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata extraction does not tolerate bad "Rating" field in EXIF #12476

Closed
bo0tzz opened this issue Sep 8, 2024 · 1 comment · Fixed by #12855
Closed

Metadata extraction does not tolerate bad "Rating" field in EXIF #12476

bo0tzz opened this issue Sep 8, 2024 · 1 comment · Fixed by #12855
Labels
good first issue Good for newcomers 🗄️server

Comments

@bo0tzz
Copy link
Member

bo0tzz commented Sep 8, 2024

Introduced in #11580. @stumpigit if you're willing to PR a fix that would be much appreciated (but no pressure).

The value probably just needs validate() called on it, and ideally a test is written to cover this case as well.

Related: #2229

[Nest] 7  - 09/08/2024, 9:43:37 AM VERBOSE [Microservices:MetadataService] Exif Tags
[Nest] 7  - 09/08/2024, 9:43:37 AM VERBOSE [Microservices:MetadataService] Object:
{
  (snip)
  "Rating": "Entity= Criteria= ",
  (...)
}

[Nest] 7  - 09/08/2024, 9:43:37 AM   ERROR [Microservices:JobService] Unable to run job handler (metadataExtraction/metadata-extraction): QueryFailedError: invalid input syntax for type integer: "Entity= Criteria= "
[Nest] 7  - 09/08/2024, 9:43:37 AM   ERROR [Microservices:JobService] QueryFailedError: invalid input syntax for type integer: "Entity= Criteria= "
    at PostgresQueryRunner.query (/usr/src/app/node_modules/typeorm/driver/postgres/PostgresQueryRunner.js:219:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async InsertQueryBuilder.execute (/usr/src/app/node_modules/typeorm/query-builder/InsertQueryBuilder.js:106:33)
    at async AssetRepository.upsertExif (/usr/src/app/dist/repositories/asset.repository.js:49:9)
    at async MetadataService.handleMetadataExtraction (/usr/src/app/dist/services/metadata.service.js:201:9)
    at async /usr/src/app/dist/services/job.service.js:148:36
    at async Worker.processJob (/usr/src/app/node_modules/bullmq/dist/cjs/classes/worker.js:394:28)
    at async Worker.retryIfFailed (/usr/src/app/node_modules/bullmq/dist/cjs/classes/worker.js:581:24)
@stumpigit
Copy link
Contributor

Thanks for the hint. I will be happy to look into this over the next few days.

@bo0tzz bo0tzz mentioned this issue Sep 10, 2024
Closed
3 tasks
@dreadster3 dreadster3 mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server): validate rating dreadster3/immich
2 participants
@stumpigit @bo0tzz