Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing ESC to clear selected assets after clicking "Select all" does not clear the selection #13481

Closed
1 of 3 tasks
zebrapurring opened this issue Oct 15, 2024 · 5 comments · Fixed by #13600
Closed
1 of 3 tasks

Pressing ESC to clear selected assets after clicking "Select all" does not clear the selection #13481

zebrapurring opened this issue Oct 15, 2024 · 5 comments · Fixed by #13600
Labels
good first issue Good for newcomers 🖥️web

Comments

@zebrapurring
Copy link

The bug

When clicking "Select all" and clearing the selection with ESC, the webapp does not properly reset the selection.

The OS that Immich Server is running on

FreeBSD

Version of Immich Server

v1.117.0

Version of Immich Mobile App

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

-

Your .env content

-

Reproduction steps

  1. Enter an album
  2. Select all assets with the "Select all" button
  3. Click ESC to clear the selection
  4. Select one single asset
  5. The "Select all" button is now still in the same state as before pressing ESC, and clicking it actually clears the current selection

Relevant log output

No response

Additional information

No response
@bo0tzz bo0tzz added good first issue Good for newcomers 🖥️web labels Oct 16, 2024
@itsme-sherlock

This comment was marked as spam.

Sign in to view
@1to5pc
Copy link

1to5pc commented Oct 17, 2024

Replicated on v1.117.0

@darrelhong darrelhong mentioned this issue Oct 19, 2024
Merged
@hacanand
Copy link

assign it to me

@bo0tzz
Copy link
Member

bo0tzz commented Oct 19, 2024

@hacanand this is already being worked on in #13600, as you can see above.

@zebrapurring
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(web): reset select all button state on escape press darrelhong/immich
5 participants
@bo0tzz @1to5pc @hacanand @zebrapurring @itsme-sherlock