feat(web): filter shared links for albums #12255
Draft
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a path to display only the shared links corresponding to an album. Changes the View links button from albums to go to this path instead of the generic sharedlinks path that displays shared links for all assets and albums.
|
This implements #9989, right? |
It implements it for albums. Arbitrary sets of assets are not supported in the current state of the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a path to display only the shared links corresponding to an album. Changes the View links button from albums to go to this path instead of the generic sharedlinks path that displays shared links for all assets and albums.
I don't know where to put a button to view links for individual shares, so this feature is only fully implemented for albums right now. Additionally, I'm not sure what the best way to handle individual shares that include multiple assets is. Should it only display shared links that contain all the selected assets or that contain any of the selected assets?