Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] diskio input for Darwin #2575

Closed
brettinternet opened this issue Mar 27, 2017 · 11 comments
Closed

[Feature Request] diskio input for Darwin #2575

brettinternet opened this issue Mar 27, 2017 · 11 comments

Comments

@brettinternet
Copy link

Feature Request

Proposal:

Support for diskio input on Darwin

For community discussion, go here: https://community.influxdata.com/t/mac-diskio-input-error-not-implemented-yet/371

Current behavior:

Leaving the default telegraf.conf configuration options on macOS installed with homebrew throws the following error in the log:

E! ERROR in input [inputs.diskio]: error getting disk io info: not implemented yet

Desired behavior:

DiskIO input with Telegraf

Use case:

System stats on a platform as prolific as macOS is essential. This includes an input as critical to Telegraf's purpose as disk IO stats.

Thanks to the InfluxData team, I appreciate all of your excellent support.

@nhaugo nhaugo added the help wanted Request for community participation, code, contribution label Mar 30, 2017
@nhaugo
Copy link
Contributor

nhaugo commented Mar 30, 2017

We get this from gopsutil, which does not provide the data for darwin.

@rburchell
Copy link

@nhaugo What are you still missing? I added IO counters for Darwin recently (hoping that telegraf would eventually pick this up)

See shirou/gopsutil#336 for reference.

@danielnelson
Copy link
Contributor

We don't compile with cgo.

@rburchell
Copy link

Ah, that's unfortunate. I don't think there's any alternative to get it unfortunately (I did a fair amount of research before settling on that).

@danielnelson
Copy link
Contributor

What I said above is wrong, we don't build for Darwin, so the cgo stuff is up to you. I'm going to update the version of gopsutil for #2649, can you test again after that gets merged?

@danielnelson danielnelson removed the help wanted Request for community participation, code, contribution label Apr 11, 2017
@rburchell
Copy link

Ah, certainly. I guess @brettinternet might be keen to as well ;-). I remember that I installed from Homebrew originally now, I had just sort of forgotten that and thought it was some kind of "official" package.

@rburchell
Copy link

Seems to work fine, at least from my (admittedly limited) testing setup :)

Disk metrics on Darwin

@danielnelson
Copy link
Contributor

For the record, I checked into this a bit more and the Homebrew package is official, and built with cgo. Here is the build script. Sorry for the misinformation.

So then it would seem we will have support for this in 1.3.0 and I'm going to close this issue.

@rburchell
Copy link

No problems, @danielnelson. Thanks for pulling in the update, I'm thrilled to have this working, and looking forward to 1.3.0 :-)

@rburchell
Copy link

@danielnelson Though this came in through an addition to third party code, is it worth adding it to CHANGELOG? I don't know how many there are like me using telegraf on Mac, but it seems reasonably noteworthy.

@danielnelson
Copy link
Contributor

Yeah, probably a good idea, I have added this issue to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants