Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to preserve conditional comments #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add option to preserve conditional comments #28

wants to merge 3 commits into from

Conversation

slackero
Copy link

@slackero slackero commented Apr 10, 2019 •
edited
Loading

Preserve conditional comments like

<!--[if lt IE 10]> Visible in IE <![endif]-->

This change is Reviewable

peter279k
peter279k reviewed Apr 30, 2019
View reviewed changes
Copy link

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you present some test cases for that?

@jenstornell
Copy link
Owner

@slackero I updated this repo today with minor fixed that can make a big impact. Your commit is a bit larger than that and I need more time to test it properly before implemented.

I guess you are using a modified version of this repo yourself? If not, there is now an option to completely disable comments as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slackero @jenstornell @peter279k