Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent test failures of TestPreload #12217

Open
minikube-bot opened this issue Aug 10, 2021 · 2 comments · Fixed by #16655
Open

Frequent test failures of TestPreload #12217

minikube-bot opened this issue Aug 10, 2021 · 2 comments · Fixed by #16655
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@minikube-bot
Copy link
Collaborator

minikube-bot commented Aug 10, 2021

This test has high flake rates for the following environments:

Environment Flake Rate (%)
QEMU_macOS 100.00
KVM_Linux_crio 100.00
@minikube-bot minikube-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 10, 2021
@spowelljr spowelljr added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 10, 2021
@minikube-bot minikube-bot reopened this Jan 25, 2022
@spowelljr spowelljr self-assigned this Jun 8, 2023
@spowelljr
Copy link
Member

spowelljr commented Jun 8, 2023

My investigation found that all VM drivers using containerd or cri-o experience this issue.

I debugged the sudo crictl images --output json command and found that it returns exit code 0, however it also outputs the following to stderr:

time="2023-06-08T20:01:39Z" level=warning msg="image connect using default endpoints: [unix:///var/run/dockershim.sock unix:///run/containerd/containerd.sock unix:///run/crio/crio.sock]. As the default settings are now deprecated, you should set the endpoint instead."
time="2023-06-08T20:01:41Z" level=error msg="connect endpoint 'unix:///var/run/dockershim.sock', make sure you are running as root and the endpoint has been started: context deadline exceeded"
time="2023-06-08T20:01:43Z" level=error msg="connect endpoint 'unix:///run/containerd/containerd.sock', make sure you are running as root and the endpoint has been started: context deadline exceeded"

This is where the issue stems from as it checks if the preload images exist, but since it's erroring it's returning an empty image list. So minikube decides it needs to untar the preload. When it untars the preload, it overwrites the directory containing all the existing images, causing the error in the test where the busybox image isn't present.

This works fine on the kicbase however, I looked at the differences between the startup process and discovered that on kicbase, we only check for the existence of the preload once, after the CRIs are configured and started, however, the VM drivers check the preload twice, once before the CRIs are configured and started, and once after. This would explain why we're getting the error output above, which in turn is causing the preload to be untarred and overwrite the existing images when it shouldn't be.

My next steps are to figure out why we're checking for the existence of the preloads twice on VM drivers and remove the one prior to the CRI configuration.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants