Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Use the appropriate method when performing a request #21

Merged
merged 1 commit into from
May 17, 2016

Conversation

aidanhs
Copy link
Collaborator

@aidanhs aidanhs commented Apr 7, 2016

This fixes droplet creation

@yo-bot
Copy link
Collaborator

yo-bot commented Apr 7, 2016

Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @kbknapp (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs aidanhs force-pushed the aphs-fix-retrieve branch from f4be29e to 5e488e4 Compare May 2, 2016 01:42
@kbknapp
Copy link
Owner

kbknapp commented May 17, 2016

@aidanhs since I haven't had a ton of time to work on this crate, if you'd like I can make you a collaborator on this project which would give you push/merge access and @homu access. Let me know if you're interested.

@kbknapp
Copy link
Owner

kbknapp commented May 17, 2016

@homu r+

@homu
Copy link
Collaborator

homu commented May 17, 2016

📌 Commit 5e488e4 has been approved by kbknapp

homu added a commit that referenced this pull request May 17, 2016
Use the appropriate method when performing a request

This fixes droplet creation
@homu
Copy link
Collaborator

homu commented May 17, 2016

⌛ Testing commit 5e488e4 with merge 68de6aa...

@homu
Copy link
Collaborator

homu commented May 17, 2016

☀️ Test successful - status

@homu homu merged commit 5e488e4 into kbknapp:master May 17, 2016
@aidanhs
Copy link
Collaborator Author

aidanhs commented May 17, 2016

@kbknapp I'm up for that.

@aidanhs aidanhs deleted the aphs-fix-retrieve branch May 17, 2016 15:11
@kbknapp
Copy link
Owner

kbknapp commented May 17, 2016

Excellent! I've added you as a collaborator, and I'll add you to @homu once I get home. Feel free to push your branches to this repo instead of a your fork if you'd like. Once I add you to homu you'll be able to use that to merge as well.

@aidanhs
Copy link
Collaborator Author

aidanhs commented May 17, 2016

Great, thanks!

@aidanhs
Copy link
Collaborator Author

aidanhs commented May 17, 2016

Oh, and could you push a new version of doapi-rs to crates.io when you get home as well? Just while you've got doapi on your mind :)

@kbknapp
Copy link
Owner

kbknapp commented May 17, 2016

Will do!

@kbknapp
Copy link
Owner

kbknapp commented May 18, 2016

@aidanhs you've been added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants