New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove promiseObject and promiseArray function syntax #119

Closed

kellyselden opened this issue Nov 15, 2016 · 0 comments

Owner

kellyselden commented Nov 15, 2016

test: promiseObject(function() {
  return this.store.findRecord('item');
})

should be

test: promiseObject(computed(function() {
  return this.store.findRecord('item');
}))

no other macros have function syntax, we should use what computed already gives us.

kellyselden mentioned this issue

remove function arg of promise macros #121

Merged

kellyselden closed this as completed in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment