Skip to content

Revert "Always use useIsFeatureEnabled() hook for feature detection"#19635

Merged
jonkoops merged 1 commit into
mainfrom
revert-19589-consistent-feature-detection
Apr 11, 2023
Merged

Revert "Always use useIsFeatureEnabled() hook for feature detection"#19635
jonkoops merged 1 commit into
mainfrom
revert-19589-consistent-feature-detection

Conversation

@jonkoops

Copy link
Copy Markdown
Contributor

Reverts #19589

@jonkoops jonkoops requested a review from a team as a code owner April 11, 2023 10:56
@ghost ghost added the team/ui label Apr 11, 2023
@jonkoops jonkoops enabled auto-merge (squash) April 11, 2023 10:56
@cypress

cypress Bot commented Apr 11, 2023

Copy link
Copy Markdown

3 flaky tests on run #6748 ↗︎

0 513 47 0 Flakiness 3

Details:

Revert "Always use `useIsFeatureEnabled()` hook for feature detection (#19589)"
Project: Keycloak Admin UI Commit: 5f9cff31da
Status: Passed Duration: 15:31 💡
Started: Apr 11, 2023 11:09 AM Ended: Apr 11, 2023 11:25 AM
Flakiness  realm_settings_tabs_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Realm settings tabs tests > Accessibility tests for realm settings > Check a11y violations on client policies tab/ profiles sub tab Output Screenshots
Flakiness  clients_saml_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Clients SAML tests > SAML keys tab > should doesn't disable signature when cancel Output Screenshots
Flakiness  realm_test.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Realm tests > should fail creating Master realm Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress

cypress Bot commented Apr 11, 2023

Copy link
Copy Markdown

@jonkoops jonkoops merged commit bcaab0e into main Apr 11, 2023
@jonkoops jonkoops deleted the revert-19589-consistent-feature-detection branch April 11, 2023 11:28
jonkoops added a commit that referenced this pull request Apr 11, 2023
ssilvert pushed a commit that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants