Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISABLED test_sdpa_mask_fp16_L6_S17_NH23_HS121 (__main__.TestSDPA) #138905

Open
pytorch-bot bot opened this issue Oct 25, 2024 · 4 comments
Open

DISABLED test_sdpa_mask_fp16_L6_S17_NH23_HS121 (__main__.TestSDPA) #138905

pytorch-bot bot opened this issue Oct 25, 2024 · 4 comments
Labels
module: flaky-tests Problem is a flaky test in CI module: macos Mac OS related issues module: mps Related to Apple Metal Performance Shaders framework skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2024 •
edited
Loading

Platforms: mac, macos

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 4 workflow(s) with 4 failures and 4 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_sdpa_mask_fp16_L6_S17_NH23_HS121
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message 
Traceback (most recent call last):
  File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/test_mps.py", line 9547, in test_sdpa_mask_fp16_L6_S17_NH23_HS121
    self._test_sdpa_mask(torch.float16, 7, 17, 23, 121)
  File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/test_mps.py", line 9535, in _test_sdpa_mask
    self._compare_tensors(y.cpu(), y_ref)
  File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/test_mps.py", line 9459, in _compare_tensors
    self.assertLess(err, 0.01)
  File "/Users/ec2-user/runner/_work/_temp/conda_environment_11490952968/lib/python3.9/unittest/case.py", line 1223, in assertLess
    self.fail(self._formatMessage(msg, standardMsg))
  File "/Users/ec2-user/runner/_work/_temp/conda_environment_11490952968/lib/python3.9/unittest/case.py", line 676, in fail
    raise self.failureException(msg)
AssertionError: nan not less than 0.01

To execute this test, run the following from the base repo dir:
    python test/test_mps.py TestSDPA.test_sdpa_mask_fp16_L6_S17_NH23_HS121

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: test_mps.py

cc @clee2000 @malfet @albanD @kulinseth @DenisVieriu97 @jhavukainen
@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: macos Mac OS related issues module: mps Related to Apple Metal Performance Shaders framework skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 25, 2024
@pytorch-bot PyTorch Bot
Copy link
Author

pytorch-bot bot commented Oct 25, 2024

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_sdpa_mask_fp16_L6_S17_NH23_HS121 (__main__.TestSDPA)
  • Platforms for which to skip the test: mac, macos
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_sdpa_mask_fp16_L6_S17_NH23_HS121 (__main__.TestSDPA) will be disabled in PyTorch CI for these platforms: mac, macos. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

How to re-enable a test

To re-enable the test globally, close the issue. To re-enable a test for only a subset of platforms, remove the platforms from the list in the issue body. This may take some time to propagate. To re-enable a test only for a PR, put Fixes #138905 in the PR body and rerun the test jobs. Note that if a test is flaky, it maybe be difficult to tell if the test is still flaky on the PR.

@pytorch-bot PyTorch Bot
Copy link
Author

pytorch-bot bot commented Oct 25, 2024

Another case of trunk flakiness has been found here. The list of platforms [mac, macos] appears to contain all the recently affected platforms [mac, macos]. Either the change didn't propogate fast enough or disable bot might be broken.

@pytorch-bot PyTorch Bot
Copy link
Author

pytorch-bot bot commented Oct 25, 2024

Another case of trunk flakiness has been found here. The list of platforms [mac, macos] appears to contain all the recently affected platforms [mac, macos]. Either the change didn't propogate fast enough or disable bot might be broken.

@pytorch-bot PyTorch Bot
Copy link
Author

pytorch-bot bot commented Oct 25, 2024

Another case of trunk flakiness has been found here. The list of platforms [mac, macos] appears to contain all the recently affected platforms [mac, macos]. Either the change didn't propogate fast enough or disable bot might be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: flaky-tests Problem is a flaky test in CI module: macos Mac OS related issues module: mps Related to Apple Metal Performance Shaders framework skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants