Repository navigation
Include of linux/limits.h breaks build on Linux <5.1 #106881
Description
Bug report
#101857 / #101858 added an #include <linux/limits.h> on Linux in Modules/posixmodule.c.
If my Linux Git history sleuthing is accurate (git log -- include/linux/limits.h), linux/limits.h only exists in Linux <3.10 and >5.1. (Yes, the file was removed then re-added.) Attempting to compile CPython against Linux headers 3.10-5.0 fails due to the missing file.
cc @thesamesam (commit author) @gpshead (reviewer)
Activity
[-]`linux/limits.h` unconditionally included and breaks build on Linux <5.1[/-][+]Include of `linux/limits.h` breaks build on Linux <5.1[/+]downloads: cpython 3.11.3 -> 3.11.4
gpshead commentedon Jul 19, 2023
the joys of headers. I suppose an additional configure.ac check can handle this.
thesamesam commentedon Jul 19, 2023
Typical! Happy to look if you don't get a chance.
justdan6 commentedon Jul 28, 2023
This looked like an easy first issue for me so I hope you don't mind that I grabbed it.
gh-106881: Check for linux/limits.h before including it (#107397)
[3.12] pythongh-106881: Check for linux/limits.h before including it (p…
[3.12] gh-106881: Check for linux/limits.h before including it (#107397…
[3.11] gh-106881: Check for linux/limits.h before including it (#107397…