Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server-level option to filter review request users #517

Open
bluekeyes opened this issue Dec 12, 2022 · 1 comment
Open

Add server-level option to filter review request users #517

bluekeyes opened this issue Dec 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bluekeyes
Copy link
Member

Internally, we have several service accounts that have elevated permissions in organizations. When using reviewer assignment for rules that are permission based, I often see service accounts assigned as reviewers, which doesn't make sense. We should add an option (probably at the server level?) to exclude users (by pattern) from review assignment when using the all-users or random-users modes.
@bluekeyes bluekeyes added the enhancement New feature or request label Dec 12, 2022
@invliD
Copy link
Member

invliD commented Oct 8, 2024

Even on a per-policy level it would be convenient to have this as an option. As an example, I have a policy that allows multiple users to approve certain changes. I do want someone to automatically get assigned for reviews (using random-users), but the list of users who can approve should be a superset of the list of users to pick from for the assignment—I want a specific user to never be assigned while retaining approval rights.

I can model this today with an or policy and two copies of the actual policy, one that requests reviews and one that doesn't, but it'd be nice to avoid that duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@invliD @bluekeyes