Hey, this doesn't have to be core functionality since you already solved it with a custom formatter :) I also use a custom formatter here: https://github.com/phpstan/phpstan/blob/2.0.x/identifier-extractor/src/ErrorFormatter.php

This project used to generate https://phpstan.org/error-identifiers has:

• collectors
• CollectedDataNode rule (https://github.com/phpstan/phpstan/blob/2.0.x/identifier-extractor/src/Rule.php) which converts the collected data into errors with metadata
• And finally, an error formatter that reads the metadata and output the final JSON: https://github.com/phpstan/phpstan/blob/2.0.x/identifier-extractor/src/ErrorFormatter.php

In your case, I'd just recommend you to also only output data to JSON that you need, in order to avoid excessive data file sizes and encode times.

Hmm, interesting.

What about this problem:

And the --error-format=json has some major downsides: the JSON can get corrupted when running with --debug or -vv. Especially during development this is annoying.

I see that you also switch between JSON and Table in the formatter:

This makes it hard for the consumer side to deal with, no?

Sure, you can do a json_validate or handle a JSON decode exception. But it feels a bit nasty.

It makes sense for this JSON formatter to always return 0. I only read the result if the exit code is 0.

As for --debug, that's tough. But you don't do that once the code works for you 😊

As for -vvv, all of those things should be printed to stderr.

Alright, then I'll keep it like this.

Thanks for the explanation. And great that my hack was not so hacky after all 😁

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.