SyncUps Tutorial: what am I doing wrong? #3224

gbuela · 2024-07-07T21:34:54Z

gbuela
Jul 7, 2024

I added the "exercise for the reader" test to check that when you delete the last attendee, a new one is added so that the list is not empty. (here)

I think I understand all the concepts presented so far and felt confident about this test but it is not passing:

    @MainActor
    func testRemoveLastAttendeeAddsNewOne() async {
        let attendee = Attendee(id: Attendee.ID())
        let store = TestStore(
            initialState: SyncUpForm.State(
                focus: .attendee(attendee.id),
                syncUp: SyncUp(
                    id: SyncUp.ID(),
                    attendees: [attendee]
                )
            )
        ) {
            SyncUpForm()
        } withDependencies: {
            $0.uuid = .incrementing
        }
        
        await store.send(.onDeleteAttendees([0])) {
            let newAttendee = Attendee(id: Attendee.ID(0))
            $0.focus = .attendee(newAttendee.id)
            $0.syncUp.attendees = [newAttendee]
        }
    }

In the SyncUpForm reducer I have used the dependency like this

            case let .onDeleteAttendees(indices):
                state.syncUp.attendees.remove(atOffsets: indices)
                guard
                    !state.syncUp.attendees.isEmpty,
                    let firstIndex = indices.first
                else {
                    state.syncUp.attendees.append(
                        Attendee(id: uuid())
                    )
                    return .none
                }
// etc

I keep getting this test result with whatever Attendee ID was created by my test.

A state change does not match expectation: …

      SyncUpForm.State(
    −   _focus: .attendee(UUID(00000000-0000-0000-0000-000000000000))
    +   _focus: .attendee(UUID(23459A3F-F6B0-4B64-8725-31A4E466E23B))
        _syncUp: SyncUp(…)
      )

(Expected: −, Actual: +)

Answered by gbuela

Jul 17, 2024

So apparently the logic that adds an attendee when you remove the last one was missing dealing with focus. As it is in the tutorial, if the focus was on the removed attendee, it is not changed to the new one. That's why I had an expectation mismatch on the focus.

I fixed it like this:

            case let .onDeleteAttendees(indices):
                state.syncUp.attendees.remove(atOffsets: indices)
                guard
                    !state.syncUp.attendees.isEmpty,
                    let firstIndex = indices.first
                else {
                    let newAttendee = Attendee(id: uuid())
                    state.syncUp.attendees.append(
                        newAttendee
…

View full answer

gbuela · 2024-07-17T00:23:03Z

gbuela
Jul 17, 2024
Author

So apparently the logic that adds an attendee when you remove the last one was missing dealing with focus. As it is in the tutorial, if the focus was on the removed attendee, it is not changed to the new one. That's why I had an expectation mismatch on the focus.

I fixed it like this:

            case let .onDeleteAttendees(indices):
                state.syncUp.attendees.remove(atOffsets: indices)
                guard
                    !state.syncUp.attendees.isEmpty,
                    let firstIndex = indices.first
                else {
                    let newAttendee = Attendee(id: uuid())
                    state.syncUp.attendees.append(
                        newAttendee
                    )
                    if let focus = state.focus,
                       case State.Field.attendee = focus {
                        state.focus = .attendee(newAttendee.id) // <-- here
                    }
                    return .none
                }

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SyncUps Tutorial: what am I doing wrong? #3224

{{title}}

Replies: 1 comment

{{title}}

Select a reply

SyncUps Tutorial: what am I doing wrong? #3224

gbuela Jul 7, 2024

Replies: 1 comment

gbuela Jul 17, 2024 Author

gbuela
Jul 7, 2024

gbuela
Jul 17, 2024
Author