Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divider: Safari don't respect empty Divider height #6012

Open
allanmcarvalho opened this issue Jul 4, 2024 · 2 comments
Open

Divider: Safari don't respect empty Divider height #6012

allanmcarvalho opened this issue Jul 4, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@allanmcarvalho
Copy link

Describe the bug

When using the Divider component in Safari without passing a Slot, a bug happens. The component below does not respect the divider padding because it is an empty DIV. I managed to get around this by putting a inside the Slot when I don't want the Divider to have text. After this, everything appears to be ok.

Reproducer

https://stackblitz.com/edit/primevue-3-vite-ts-issue-template-xus7rx?file=src%2FApp.vue

PrimeVue version

3.53.0

Vue version

4.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Safari 17.5

Steps to reproduce the behavior

Put Divider without Slot content, add a bellow content and see te output on Safari.

Expected behavior

The bellow content don't respect Divider height and stay together with it's line.
@allanmcarvalho allanmcarvalho added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 4, 2024
@midyro
Copy link

midyro commented Aug 21, 2024 •
edited
Loading

I'm facing the same issue. It seems that this problem is also present in Primevue 4. I checked if this problem is also in the Angular version of the Divider component, but that seems to work just fine in Safari. The code is mostly the same.

@nicolascvoodoo
Copy link

Same issue here with PrimeVue 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@midyro @allanmcarvalho @nicolascvoodoo