Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password. When disabled, you can tab to it and type value anyway. #10483

Open
iskalyakin opened this issue Aug 6, 2021 · 2 comments
Open

Password. When disabled, you can tab to it and type value anyway. #10483

iskalyakin opened this issue Aug 6, 2021 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Status: Pending Review Issue or pull request is being reviewed by Core Team

Comments

@iskalyakin
Copy link

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/edit/primeng-password-demo-100?file=src%2Fapp%2Fapp.component.ts

Current behavior
Make password field disabled. After it component doesn't react on click, but can be focused and edited by tab.

Expected behavior
Disabled password component shouldn't be accessable either by click or tab.

Minimal reproduction of the problem with instructions
Minimal demo: https://stackblitz.com/edit/primeng-password-demo-100?file=src%2Fapp%2Fapp.component.ts
Steps:

  1. Make password field disabled.
  2. Tab to it. You can, and it seems like an issue.

What is the motivation / use case for changing the behavior?
Current behavior can lead to forms filling issues for users.

Please tell us about your environment:
ubuntu 18.04, yarn.

  • Angular version: 5.X
    12.0.1

  • PrimeNG version: 5.X
    12.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    all

  • Node (for AoT issues): node --version =
    all
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 6, 2021
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@iskalyakin
Copy link
Author

Hi. Thank you for the answer. Unfortunatly, it looks like this problem is still here, at least in 13 version (which is used for password component example).
https://stackblitz.com/edit/primeng-password-demo-kaqf6r?file=src%2Fapp%2Fapp.component.html

@mertsincan mertsincan reopened this Nov 11, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mertsincan @yigitfindikli @iskalyakin