fix(scan): add compliance info inside finding #5649
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to improve the provider model names, update the
scan
method, and enhance the handling of compliance frameworks and checks metadata. The most important changes include fixing typos in model names, updating thescan
method to useNone
as the default value forcustom_checks_metadata
, and incorporating bulk compliance frameworks and checks metadata.Provider Model Names Fixes:
docs/developer-guide/provider.md
: Corrected typos in provider model names fromProvierSessionModel
,ProvierIdentityModel
, andProvierOutputOptionsModel
toProviderSessionModel
,ProviderIdentityModel
, andProviderOutputOptionsModel
respectively. [1] [2]Scan Method Updates:
prowler/lib/scan/scan.py
: Changed the default value ofcustom_checks_metadata
from an empty dictionary toNone
in thescan
method.Compliance Frameworks and Checks Metadata:
prowler/lib/scan/scan.py
: Added logic to load bulk compliance frameworks and get bulk checks metadata for the provider, then update the checks metadata with the compliance framework specification.prowler/lib/scan/scan.py
: Updated thescan
method to use theProviderOutputOptions
instance for generating findings output.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.