feat(s3): add new fixer s3_bucket_public_write_acl_fixer
#5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5855 +/- ##
==========================================
+ Coverage 89.86% 90.00% +0.14%
==========================================
Files 1136 1154 +18
Lines 35452 35711 +259
==========================================
+ Hits 31858 32142 +284
+ Misses 3594 3569 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I have now my personal account working and I've been able to test on real infrastructure the fixer, as it works as expected this PR is now ready for review. |
MrCloudSec
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Develop a fixer that removes public write access from the ACLs of S3 buckets. The fixer will ensure that only authorized users or IAM roles can write to the bucket, preventing unauthorized modifications and protecting sensitive data stored in S3.
This fixer is already done and tested in moto but I don’t want to test it on real infra until I discuss with someone else because for creating a bucket with public write access it’s needed to change the “BlockPublicAcls” parameter at bucket and account level and this could affect to the other s3 buckets that are currently on our AWS ProwlerDev account. So, for this reason, I'll left this PR in draft.
Description
Added a new fixer
s3_bucket_public_write_acl_fixerwith its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.