New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZipOutputStream should encode using UTF-8 #7400

Open

eed3si9n opened this issue Oct 8, 2023 · 0 comments

Labels

Bug good first issue

Member

eed3si9n commented Oct 8, 2023

problem

https://github.com/sbt/io/blob/2656359e9ce42dc7e901277775bd66e3e9ccd4f3/io/src/main/scala/sbt/io/IO.scala#L762

case None => (new ZipOutputStream(fileOut), "zip")

expectation

We should encode the entries in zip by passing in UTF-8 to the ctor.

eed3si9n added the Bug label

Friendseeker added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment