Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Step 4: Add branch protections - ruleset or classic rule? #71

Open
TrangOul opened this issue Aug 20, 2024 · 1 comment
Open

[Bug] Step 4: Add branch protections - ruleset or classic rule? #71

TrangOul opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TrangOul
Copy link

Summary

There is a new branch protection setting ("ruleset") which this tutorial is not aware of.

How to reproduce

  1. Complete Steps 1-3, so the current one is Step 4: Add branch protections
  2. Follow the first step in the Activity: Add branch protections:
    Go to Branches settings. You can navigate to that page manually by selecting the right-most tab in the top of the repository called Settings and then clicking Branches.
  3. Notice that there are two settings available: Add branch ruleset and Add classic branch protection rule, which are not consistent with step 2:
    Click Add branch protection rule under "Branch protection rules".

image

Additional context

Please update the tutorial so it uses the new branch ruleset (better) or change it so it's clear to use a classic branch protection rule (worse, but acceptable as a hotfix).

@TrangOul TrangOul added the bug Something isn't working label Aug 20, 2024
@nguyenalex836
Copy link

@TrangOul Thank you for raising this issue! ✨ I'll triage this for the team to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants