Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Hack language server with .hhconfig not in root #94

Open
bigfootjon opened this issue Jun 22, 2020 · 2 comments
Open

Enable Hack language server with .hhconfig not in root #94

bigfootjon opened this issue Jun 22, 2020 · 2 comments

Comments

@bigfootjon
Copy link

I have a repository that uses a few different programming languages and in order to keep things clean I put the dotfiles to support each language in the folder containing that language's code.

It seems like this extension only supports .hhconfig in the root of the workspace. Would it be possible to support workspaceContains:**/.hhconfig? Or alternatively to add onLanguage:hack to activationEvents?

I'm willing to write and test a Pull Request if this would be an acceptable change?
@Wilfred
Copy link
Contributor

Wilfred commented Jun 22, 2020

That seems reasonable to me, at least.

I'm sure our tooling assumes that .hhconfig is the root directory of any Hack code, so we'd want to check it actually works in your scenario :)

@PranayAgarwal
Copy link
Member

onLanguage:hack makes sense to me, although I'm curious to know how hh_client itself handles your setup. If you want to open a PR for it I'll be happy to approve.

@bigfootjon bigfootjon mentioned this issue Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Hack root in an arbitrary subdirectory bigfootjon/vscode-hack
3 participants
@Wilfred @PranayAgarwal @bigfootjon