Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send_by_ref by modelling it like get_by_ref. #791

Open
wants to merge 1 commit into
base: vehre/add-clang-format
Choose a base branch
from
Open

Fix send_by_ref by modelling it like get_by_ref. #791

wants to merge 1 commit into from

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Oct 15, 2024 •
edited
Loading

coverage on master
Codecov branch

Summary of changes

Send_by_ref was working as expected for static arrays and arrays of higher rank.

Rationale for changes

Make send_by_ref to work for static arrays and arrays of higher rank. This fixes #654.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

@vehre
Model send_by_ref according to get_by_ref.
f9a68b9 
Make send_by_ref stable and its structure the same as get_by_ref.
Add a "dummy" component into the test's derived type to figure
incorrect offset computation.
@vehre vehre requested review from zbeekman and rouson October 15, 2024 13:01
@vehre
Copy link
Collaborator Author

vehre commented Oct 15, 2024

This fix also fixes the last open testsuite failure get_static_array.f90. It was tested with mpich 4.1.2, openmpi 4.1.5 and intel mpi 2021.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeekman zbeekman Awaiting requested review from zbeekman

@rouson rouson Awaiting requested review from rouson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vehre