Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

damage examine should not be available if the damage is zero #33052

Open
lzk228 opened this issue Oct 29, 2024 · 3 comments · Fixed by #33061 · May be fixed by #33064
Open

damage examine should not be available if the damage is zero #33052

lzk228 opened this issue Oct 29, 2024 · 3 comments · Fixed by #33061 · May be fixed by #33064
Labels
Status: Untriaged Somebody go through and give this appropriate labels

Comments

@lzk228
Copy link
Contributor

lzk228 commented Oct 29, 2024

like what
image
@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Oct 29, 2024
@thetolbean thetolbean mentioned this issue Oct 29, 2024
Merged
2 tasks
@PJB3005
Copy link
Member

PJB3005 commented Oct 30, 2024

Re-opening since PR did not fix this.

@PJB3005 PJB3005 reopened this Oct 30, 2024
@thetolbean
Copy link
Contributor

I mistakenly thought this was specifically about the plushies.
From what I've seen about this issue, it looks like the consensus is to provide the button, but have alternative text that it deals no damage if the damage is 0.
I'll go back and provide a more robust fix.
(Second try is the charm)

@thetolbean thetolbean linked a pull request Oct 30, 2024 that will close this issue
Open
2 tasks
@thetolbean
Copy link
Contributor

Alright, try two. This fix is more general and works for any item that is a weapon, but has a damage of 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Untriaged Somebody go through and give this appropriate labels
Projects
None yet
Milestone
No milestone
3 participants
@PJB3005 @thetolbean @lzk228