From 3d92168f105c29bf317f2d3e4346e6d6a47e8715 Mon Sep 17 00:00:00 2001 From: zcorpan Date: Thu, 7 Nov 2024 22:31:38 +0100 Subject: [PATCH 1/4] Percentage height quirk should apply to flex and grid items Fixes https://github.com/w3c/csswg-drafts/issues/5545. --- quirks.bs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/quirks.bs b/quirks.bs index 482f600..1ee2eae 100644 --- a/quirks.bs +++ b/quirks.bs @@ -256,8 +256,8 @@ the first step that returns a value: ''height/auto'', then return |element|.
  • If |element| has a computed value of the 'position' property that is - ''position/absolute'', or if |element| is a not a block container or a - table wrapper box, then return |element|. + ''position/absolute'', or if |element| is a not a block box, a + table wrapper box, a flex item, or a grid item, then return |element|.

  • Jump to the first step. From 5118363ed6de70120e67ad7b8e561861dd19e087 Mon Sep 17 00:00:00 2001 From: zcorpan Date: Mon, 17 Feb 2025 21:02:37 +0100 Subject: [PATCH 2/4] Address comments --- quirks.bs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/quirks.bs b/quirks.bs index 1ee2eae..1f1e3c0 100644 --- a/quirks.bs +++ b/quirks.bs @@ -255,9 +255,18 @@ the first step that returns a value:

  • If |element| has a computed value of the 'height' property that is not ''height/auto'', then return |element|. -

  • If |element| has a computed value of the 'position' property that is - ''position/absolute'', or if |element| is a not a block box, a - table wrapper box, a flex item, or a grid item, then return |element|. +

  • +

    If the following conditions are true, then return |element|:

    + +
      +
    1. |element| has a computed value of the 'position' property that is + ''position/absolute'' + +

    2. |element| is a not a block box, nor an inline-block, nor a block-level or + inline-level table wrapper box + +

    3. |element| is a flex item or a grid item +

  • Jump to the first step. From 46c8bd057c3d1bfd1d59022b2a6ac89a45174850 Mon Sep 17 00:00:00 2001 From: zcorpan Date: Tue, 18 Feb 2025 12:40:24 +0100 Subject: [PATCH 3/4] Any of --- quirks.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quirks.bs b/quirks.bs index 1f1e3c0..51fc062 100644 --- a/quirks.bs +++ b/quirks.bs @@ -256,7 +256,7 @@ the first step that returns a value: ''height/auto'', then return |element|.

  • -

    If the following conditions are true, then return |element|:

    +

    If any of the following conditions are true, then return |element|:

    1. |element| has a computed value of the 'position' property that is From e9fd219fb8e2dd6481cbed003629fd0bf28e53a4 Mon Sep 17 00:00:00 2001 From: zcorpan Date: Tue, 18 Feb 2025 12:42:45 +0100 Subject: [PATCH 4/4] Fix link error --- quirks.bs | 1 + 1 file changed, 1 insertion(+) diff --git a/quirks.bs b/quirks.bs index 51fc062..190f26e 100644 --- a/quirks.bs +++ b/quirks.bs @@ -77,6 +77,7 @@ spec:css-display-4 type:property; text:display type:dfn; text:containing block type:dfn; text:initial containing block + type:dfn; text:block box