Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide solution buttons #80

Open
4flixt opened this issue May 5, 2021 · 7 comments
Open

Show/hide solution buttons #80

4flixt opened this issue May 5, 2021 · 7 comments

Comments

@4flixt
Copy link

4flixt commented May 5, 2021

Dear @willkessler,

we have encountered a problem with the show/hide solution buttons in JupyterGraffiti (1.0.1.18).
It seems like the feature to create a solution box doesn't write a new file. If we want to display the solution, we obtain:
MicrosoftTeams-image
Note that the used kernel is "Python 3" (also visible in the figure). Interestingly, we are able to record and play voice recordings in the same setup.

We experienced the problem on various Windows machines and have also worked with Docker. Even with Docker the problem persists. On MacOSX everything works fine for some reason.

We currently work around the problem by using the "old" method of manually creating files and linking them to the solution button.

@willkessler
Copy link
Owner

i'll try to look into this next week sometime

@4flixt
Copy link
Author

4flixt commented May 7, 2021

Thank you Will :)

@willkessler
Copy link
Owner

Hi there,

Just got around to testing this. I can't reproduce. (I'm on ubuntu). When I try for instance on binder, it's fine. (This link )

Can you provide precise steps to reproduce?

Thank you.

@4flixt
Copy link
Author

4flixt commented May 16, 2021

hey will :) I just gave it a shot on binder as well. First it seemed that the problem did indeed show but it turned out that I had to wait a couple of seconds after creating the solution button:

Screen.Recording.2021-05-16.at.21.24.40.mov

so at least I am not crazy :D I think I didnt wait the last time i tried it on binder ... I'll check with my collegues working on windows if that is their problem as well (but somehow I don't think so). Will let you know asap. Thanks for checking though!

@willkessler
Copy link
Owner

Aha yes, there's some lag as the code has to go through the backend of jupyter to write the file out. Locally, though, it should be fairly quick. But let me see if I can repro that raciness locally, maybe there's a fix for that.

Separately, I'm going to try to get a new release out for you that will allow for alternative kernels.

@willkessler
Copy link
Owner

OK I tried to replicate the problem locally, and can't. If there's a race condition, I can't beat it yet.

@willkessler
Copy link
Owner

@4flixt I've release 1.0.1.19 which uses %%writefile to save Graffiti if the kernel is an unknown kernel. This means any (probably Python-based) kernel that supports this magic command will work now, so you can feel free to try your non python3 kernels and let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants