Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #206 add flag to list projects also matching group name #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dosmanak
Copy link

No description provided.

@dosmanak
Copy link
Author

Not sure how to make test for my change, sorry.

@dosmanak
Copy link
Author

The test failes becaut the test repo is different than expected. That is not my fault ;-)

@prarit
Copy link
Collaborator

prarit commented Oct 12, 2022

@dosmanak , sorry for the delay in response. I'm not sure all your code is in this MR? AFAICT you've only added the -g option but I don't see what you do with it.

Owned: gitlab.Bool(projectListConfig.Owned),
Membership: gitlab.Bool(projectListConfig.Membership),
Starred: gitlab.Bool(projectListConfig.Starred),
SearchNamespaces: gitlab.Bool(projectListConfig.Group),
Copy link
Author

@dosmanak dosmanak Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply pass the flag -g as boolean parameter which sets the SearchNamespaces boolean for the gitlab SDK github.com/xanzy/go-gitlab SDK

which translates into gitlab API call.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants