Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add to timeouts for query operations in integration tests #8896

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Nov 12, 2024

Draft to test hypothesis that the timeout is to short for the pipeline performance in the integration tests.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:02pm

Copy link

Thanks for your contribution @stebenz! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f45f52e). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/integration/assert.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8896   +/-   ##
=======================================
  Coverage        ?   62.52%           
=======================================
  Files           ?     1538           
  Lines           ?   143987           
  Branches        ?        0           
=======================================
  Hits            ?    90029           
  Misses          ?    49602           
  Partials        ?     4356           
Flag Coverage Δ
core-integration-tests-postgres 36.20% <ø> (?)
core-unit-tests 46.70% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant