Page MenuHomePhabricator

No loading animation when editing a section deep down a page
Closed, ResolvedPublic8 Estimated Story Points

Description

For example, try clicking [edit] at [[Glossary of chess#G]]. The text just goes gray, there is no indication that anything is happening.

This is because the progress indicator always appears at the top of the page.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53217

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM
bzimport set Reference to bz50206.

Argh, missed this one in the bunch of other fixes; sorry. Thanks for the spot!

  • Bug 51785 has been marked as a duplicate of this bug. ***
  • Bug 51830 has been marked as a duplicate of this bug. ***

So we just want to fix the loading bar at a certain position on the screen?

I'm thinking of something like this in modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css under ".ve-init-mw-viewPageTarget-loading {":

  • float: right;

+ position: fixed;
+ right: 5%;
+ top: 16%;

Seems reasonable, although we might want to make it stand out against non-flat-white backgrounds.

(In reply to comment #5)

Seems reasonable, although we might want to make it stand out against
non-flat-white backgrounds.

Put it in with a pure-white background with a 2px margin, then? Maybe Trevor has a view re. design?

(In reply to comment #6)

(In reply to comment #5)

Seems reasonable, although we might want to make it stand out against
non-flat-white backgrounds.

Put it in with a pure-white background with a 2px margin, then? Maybe Trevor
has a view re. design?

I tried this but it still appeared over the top of text. :/

I've merged in two related bug reports--please note that these bugs bring up an additional usability issue. If the GUI is not disabled during load, the editor can end up in an annoying situation, such as manually scrolling to the section to edit, then having their work bumped off the page by the onLoad scroll action.

Jdforrester-WMF renamed this task from VisualEditor: No loading animation when editing a section deep down a page to No loading animation when editing a section deep down a page.Mar 16 2015, 4:36 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set Security to None.

Change 196583 had a related patch set uploaded (by Trevor Parscal):
Make loading progress bar determinate

https://gerrit.wikimedia.org/r/196583

Change 196583 merged by jenkins-bot:
Make loading progress bar determinate

https://gerrit.wikimedia.org/r/196583