The following items should support opening in new tabs:
- Search results
- Nearby
- Disambiguation links
- Read more links
• Niedzielski | |
Jun 26 2015, 3:20 AM |
F1904069: Screenshot_2015-08-19-14-38-44.jpg | |
Aug 19 2015, 9:47 PM |
F1904007: Screenshot_2015-08-19-14-30-36.png | |
Aug 19 2015, 9:47 PM |
F1904009: Screenshot_2015-08-19-14-30-44.png | |
Aug 19 2015, 9:47 PM |
F1496646: screenshot-2015-08-14-14-40-48-132352559.png | |
Aug 14 2015, 8:47 PM |
The following items should support opening in new tabs:
ISBN links should not have the option to open in new tabs if they open out of app instead.
Change 226130 had a related patch set uploaded (by Dbrant):
Add long-press menu to Search, Nearby, Disambig, and Read More.
@Dbrant Since your patch does not include Saved pages and History items, I think you might want to adjust the title and description of this task to reflect that.
Change 226130 merged by jenkins-bot:
Add long-press menu to Search, Nearby, Disambig, and Read More.
I understand the objective here is to consistently support the 'Open in a new tab' behavior, but this requires some discussion.
It feels a little bit strange to long press in a search or a list context.
Can we move this to the next sprint and I will collect some feedback on this in the design review on Tuesday.
Did a quick checking - opening in new tabs(via long-press) is available from
Interaction looks good.
The select color goes from green to blue. Can we stick with a muted grey like suggested in Mdesign?
The order of action should support frequency of behavior
-Open
-Open in new tab
-Save Page
-Share link
-Copy link address
Change 231687 had a related patch set uploaded (by Niedzielski):
Tweak long press menu order
Checked with 2.0.108-alpha-2015-08-19 on Nexus5(Android 5.1) - notice the absence of a blue-colored article title.
Samsung Tablet Ce0168(Android 4.0.4) with 2.0.108-alpha-2015-08-19 looks as the screenshot @Niedzielski added: