Unsuccessful automatic migration:
CentralNotice: https://gerrit.wikimedia.org/r/#/c/186899/
Conditional initialization is an issue. We're considering using the callback mechanism to continue doing the conditional stuff programmatically.
This task is important because it should improve overall site performance.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Migrate to extension registration | mediawiki/extensions/CentralNotice | master | +1 K -1 K |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | None | T87875 Convert all Wikimedia-deployed extensions and skins to use extension registration | ||
| Resolved | awight | T95832 [epic] Migrate fundraising extensions to the new format | ||
| Resolved | AndyRussG | T108721 Convert CentralNotice to use extension registration | ||
| · · · |
We have a problem here, that extension setup is controlled by conditionals, and different hooks are registered on infrastructure vs subscribing wikis. See efCentralNoticeSetup.
@Paladox gave us the answer to conditional initialization, that for now we can write a callback function for that junk. Once that's working, we can consider something fancier like sub-extension configuration.
@awright I am not sure what your asking. But yes you have to use a callback currently.
But anyways it dosent need a callback it already uses the ExtensionFunctions config which does it.
Change 186899 had a related patch set uploaded (by Awight):
[WIP] Add extension.json, empty php entry point
@DStrine @atgo @AndyRussG
I'd like to pull this one in before the code freeze, a lot of work went into the patch and a rebase in January would be too difficult. There's also a decent chance that we'll be ambushed by a surprise requirement to become compatible with MediaWiki extension registration, doing it ahead of time avoids that risk.
Change 186899 had a related patch set uploaded (by Paladox):
[WIP] Add extension.json, empty php entry point
Finished tweaking and smoke testing! Some else should do review the additional changes I made, though, I think. :) Thx!!!!
Following deploy, a single error was discovered on production, leading to the patch below, also now deployed!