Page MenuHomePhabricator
Create Task
Maniphest T128282

[Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

See https://de.wikipedia.org/wiki/Liste_der_Tabellenf%C3%BChrer_der_Fu%C3%9Fball-Bundesliga?veaction=edit .
In Firefox, double click on any cell will cause the page to scroll down; the table options pop-up appears right below the table, and I can't access cell's contents anyway.
(Per Diwas, current workaround is clicking + pressing Enter).

Details

SubjectRepoBranchLines +/-
Ensure table cells are ce=true before computing offsetsVisualEditor/VisualEditorwmf/1.27.0-wmf.16+4 -2
Ensure table cells are ce=true before computing offsetsVisualEditor/VisualEditormaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Feb 27 2016, 5:41 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 27 2016, 5:41 PM
• Elitre mentioned this in T128299: Table editing in VisualEditor broken for Firefox.Feb 28 2016, 5:47 PM
Jdforrester-WMF renamed this task from In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents to [Regression] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents.Feb 28 2016, 11:39 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: Browser-Support-Firefox.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Esanders.
DLynch subscribed.Feb 29 2016, 3:34 PM

I actually updated Firefox from 42 to 43 while checking this out, and the issue wasn't happening in 42 but started happening after the update, so it might be some sort of regression in Firefox itself.

Jdforrester-WMF renamed this task from [Regression] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents to [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents.Feb 29 2016, 4:01 PM
Trizek-WMF subscribed.Feb 29 2016, 5:38 PM
The_RedBurn merged a task: T128299: Table editing in VisualEditor broken for Firefox.Mar 1 2016, 4:31 PM
The_RedBurn added subscribers: bd808, Srdjan, jeblad.
Jdforrester-WMF merged a task: T128439: Cell editing functionality bug: user can replace entire text contents of a cell but can't selectively edit the text.Mar 1 2016, 8:09 PM
Jdforrester-WMF added a subscriber: Pine.
• Elitre mentioned this in T128825: Double-clicking on a block transclusion that takes up most of the visible space inside a table cell doesn't edit the cell or edit the transclusion.Mar 4 2016, 6:10 PM
Samat subscribed.Mar 4 2016, 6:27 PM
Tgr subscribed.Mar 4 2016, 9:54 PM

In some contexts, single click scrolls to bottom as well (and selects all contents). See T128825 and this video.

• Elitre mentioned this in T129066: Impossibility to type Japanese characters in a table cell on VE by using Firefox.Mar 7 2016, 4:29 PM
Jdforrester-WMF added a subscriber: dchan.Mar 9 2016, 1:05 AM
Frakir subscribed.Mar 9 2016, 2:36 PM
Jdforrester-WMF merged a task: T129267: Double-clicking a table cell doesn't work in Firefox.Mar 9 2016, 4:57 PM
Jdforrester-WMF added a subscriber: • Catrope.
jeblad added a comment.Mar 12 2016, 9:16 PM

Double clicking opens the last table cell for editing, no matter which cell is double clicked. A testpage exist at nowiki.

Mannivu merged a task: T128588: Unable to edit table cell after double click on cell .Mar 13 2016, 12:48 PM
Mannivu subscribed.
Esanders added a comment.Mar 13 2016, 1:30 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/270254/

gerritbot subscribed.Mar 13 2016, 7:48 PM

Change 277104 had a related patch set uploaded (by Esanders):
Ensure table cells are ce=true before computing offsets

https://gerrit.wikimedia.org/r/277104

gerritbot added a project: Patch-For-Review.Mar 13 2016, 7:48 PM
gerritbot added a comment.Mar 13 2016, 8:33 PM

Change 277104 merged by jenkins-bot:
Ensure table cells are ce=true before computing offsets

https://gerrit.wikimedia.org/r/277104

gerritbot added a comment.Mar 14 2016, 12:59 AM

Change 277181 had a related patch set uploaded (by Jforrester):
Ensure table cells are ce=true before computing offsets

https://gerrit.wikimedia.org/r/277181

Jdforrester-WMF assigned this task to Esanders.Mar 14 2016, 1:02 AM
Jdforrester-WMF added projects: MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)), MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).
gerritbot added a comment.Mar 14 2016, 1:03 AM

Change 277181 merged by jenkins-bot:
Ensure table cells are ce=true before computing offsets

https://gerrit.wikimedia.org/r/277181

Trizek-WMF added a project: User-notice.Mar 14 2016, 3:00 PM
Trizek-WMF moved this task from To Triage to Not ready to announce on the User-notice board.Mar 14 2016, 3:03 PM
Jdforrester-WMF closed this task as Resolved.Mar 14 2016, 4:07 PM
Jdforrester-WMF removed a project: Patch-For-Review.
• Elitre awarded a token.Mar 14 2016, 4:21 PM
Trizek-WMF moved this task from Not ready to announce to Announce in next Tech/News on the User-notice board.Mar 14 2016, 4:21 PM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Mar 17 2016, 7:29 AM
tarlocesilion awarded a token.Mar 19 2016, 6:05 PM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 24 2016, 9:50 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice, MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits