Page MenuHomePhabricator
Create Task
Maniphest T189428

Notifications: Preferences popup `z-index` issue
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Volker_E
Mar 11 2018, 10:01 PM
Tags
Referenced Files
F15503623: Screen Shot 2018-03-15 at 5.12.52 PM.png
Mar 15 2018, 1:14 PM
F15144547: T189428 Notifications pref popup - Wikipedia 2018-03-11.png
Mar 11 2018, 10:02 PM
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot
Mooeypoo
Volker_E
Tokens
"Haypence" token, awarded by RandomDSdevel.

Description

When there isn't enough vertical space and the notifications pops-up to the top, it doesn't go on “top”:

T189428 Notifications pref popup - Wikipedia 2018-03-11.png (602×668 px, 57 KB)

Details

SubjectRepoBranchLines +/-
Place the notification page settings popup in an overlaymediawiki/extensions/Echomaster+2 -1
Customize query in gerrit

Event Timeline

Volker_E created this task.Mar 11 2018, 10:01 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 11 2018, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E updated the task description. (Show Details)Mar 11 2018, 10:02 PM
gerritbot subscribed.Mar 11 2018, 10:18 PM

Change 418833 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Echo@master] Place the notification page settings popup in an overlay

https://gerrit.wikimedia.org/r/418833

gerritbot added a project: Patch-For-Review.Mar 11 2018, 10:18 PM
Mooeypoo claimed this task.Mar 11 2018, 10:19 PM
Mooeypoo edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Mar 14 2018, 8:23 PM

Change 418833 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Place the notification page settings popup in an overlay

https://gerrit.wikimedia.org/r/418833

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 14 2018, 9:00 PM
Mooeypoo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 14 2018, 9:19 PM
Etonkovidova closed this task as Resolved.Mar 15 2018, 1:14 PM
Etonkovidova subscribed.

Fixed in betalabs:

Screen Shot 2018-03-15 at 5.12.52 PM.png (228×541 px, 27 KB)

RandomDSdevel awarded a token.Apr 2 2018, 1:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits