Page MenuHomePhabricator

language/spelling variant selector on Special:NewItem and Special:NewLexeme stays open when tabbing out of it, covering other input fields
Closed, ResolvedPublic8 Estimated Story Points

Description

Problem:
When using Special:NewItem and Special:NewLexeme using keyboard navigation then the language selectors are covering other input fields. This is very annoying for editors as it makes it hard to continue creating the Item or Lexeme.

Steps to reproduce:

On Special:NewItem:

  1. go to https://www.wikidata.org/wiki/Special:NewItem
  2. click into the language field
  3. select a language
  4. tab out of the language field
  5. tab again to the next field
  6. observe the language selector opening again

On Special:NewLexeme:

  1. go to https://www.wikidata.org/wiki/Special:NewLexeme
  2. fill in a Lemma
  3. fill in a "Language for Lexeme" that's not a standard language (try "Maldives" 📦
  4. fill in a "Spelling variant of the Lemma"
  5. tab out of the spelling variant field
  6. tab again to the next field
  7. observe the language selector opening again

Acceptance criteria:

  • language selector stays closed when tabbing out of the language field on Special:NewItem
  • spelling variant selector stays closed when tabbing out of the spelling variant field on Special:NewLexeme

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Task inspection note:
We should test this on an older OOUI version to determine if that's the cause.

Tested on OOUI version 0.38.0, 0.39.0 and 0.40.3 the bug is the same on all 3 versions.

@rosalieper and I looked at this and filed T268139: ComboBoxInputWidget: does not close when tabbing out with selected value as it seems this is a problem in upstream OOUI as well and probably should be fixed there. We may not be the best candidates to try and fix this in the upstream ourself, because there are probably people who can do this quicker than us.

This is waiting for the next OOUI release, may be verified after that.