Page MenuHomePhabricator

docs: Add configurable Card demo
Open, Needs TriagePublic

Description

It should be possible to configure a Card to experiment with it

Note that for the thumbnail, to change the image requires first removing it entirely, the controls should include a note about that. (T312540)

For the thumbnail, it appears that the width/height properties aren't actually used at all, and so do not need to be configurable yet (and probably should not be available, to avoid confusion). (T312580)

The Card component assumes that the title slot is set, in that it is unconditionally rendered with a surrounding span. There is no way (yet) to make the controls enforce required slots like this, hopefully once T309905 is done such non-empty validation can be added.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 818555 had a related patch set uploaded (by DannyS712; author: DannyS712):

[design/codex@main] docs, Card: add a configurable Card demo

https://gerrit.wikimedia.org/r/818555

Volker_E renamed this task from Add configurable Card demo to docs: Add configurable Card demo.Sep 21 2022, 10:49 PM
Volker_E added a project: Documentation.

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.