Maniphest T321104

Integration Tests: Look into testing-library to improve test readability
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ddwaal
	Oct 18 2022, 4:48 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Look into any existing external libraries we could use to improve component selection in tests to

improve readability of tests by selecting User facing labels/text rather than class selectors.
avoid having to update tests in the future due to DOM structure refactors.

Suggested library: https://github.com/testing-library/vue-testing-library

Also, look into using waitFor method in this testing library instead of explicitly choosing a number of ticks in our current awaitTicks method.
https://testing-library.com/docs/dom-testing-library/api-async/#waitfor

See discussion on patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/839618

Desired behavior/Acceptance criteria
n/a

Devices and Design (URLs or screenshots)
n/a

Desktop: ...
Small screens/mobile: ...

n/a

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	Use Vue Testing Library in all FE integration tests.	mediawiki/extensions/WikiLambda	master	+1 K -2 K
	Run app in Vue 3 mode.	mediawiki/extensions/WikiLambda	master	+152 -167

Customize query in gerrit

Related Objects

Duplicates Merged Here: T321107: Integration Tests: Look into factory methods for generating zObjects across production code + tests

Event Timeline

Ddwaal created this task.Oct 18 2022, 4:48 PM

This comment was removed by Ddwaal.

Ddwaal updated the task description. (Show Details)Oct 18 2022, 4:51 PM

Jdforrester-WMF merged a task: T321107: Integration Tests: Look into factory methods for generating zObjects across production code + tests.Oct 18 2022, 6:37 PM

DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Oct 18 2022, 6:37 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

gengh moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 8 2022, 3:52 PM

EWright claimed this task.Nov 14 2022, 4:54 PM

Change 858630 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Cease running Jest tests in Vue compat mode.

https://gerrit.wikimedia.org/r/858630

gerritbot added a project: Patch-For-Review.Nov 21 2022, 12:01 PM

Jdforrester-WMF moved this task from Phase θ – Throttling to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 21 2022, 8:26 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase θ – Throttling).

Change 859058 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] Use Vue Testing Library in all FE integration tests.

https://gerrit.wikimedia.org/r/859058

(adding back onto Phase Theta board to reflect conversation at last Experience Planning meeting, where it was agreed I would prioritise this)

Change 858630 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Run app in Vue 3 mode.

https://gerrit.wikimedia.org/r/858630

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 28 2022, 5:01 PM

Change 859058 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Use Vue Testing Library in all FE integration tests.

https://gerrit.wikimedia.org/r/859058

Maintenance_bot removed a project: Patch-For-Review.Nov 30 2022, 3:29 PM

EWright moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 30 2022, 3:31 PM

Jdforrester-WMF closed this task as Resolved.Dec 2 2022, 12:45 AM