Page MenuHomePhabricator

Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in PhonosButton.less
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. in PhonosButton.less
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Parser.php(2668)
#0 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Parser.php(446): Less_Parser->Error(string)
#1 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(265): Less_Parser->parseFile(string, string, boolean)
#2 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(190): Less_Tree_Import->ParseImport(string, string, Less_Environment)
#3 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(239): Less_Tree_Import->compile(Less_Environment)
#4 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(227): Less_Tree_Ruleset->evalImports(Less_Environment)
#5 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(69): Less_Tree_Ruleset->PrepareRuleset(Less_Environment)
#6 /srv/mediawiki/php-1.40.0-wmf.12/vendor/wikimedia/less.php/lib/Less/Parser.php(190): Less_Tree_Ruleset->compile(Less_Environment)
#7 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/FileModule.php(1127): Less_Parser->getCss()
#8 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/FileModule.php(1010): MediaWiki\ResourceLoader\FileModule->compileLessString(string, string, MediaWiki\ResourceLoader\DerivativeContext)
#9 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/FileModule.php(986): MediaWiki\ResourceLoader\FileModule->processStyle(string, string, string, MediaWiki\ResourceLoader\DerivativeContext)
#10 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/FileModule.php(964): MediaWiki\ResourceLoader\FileModule->readStyleFile(string, MediaWiki\ResourceLoader\DerivativeContext)
#11 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/FileModule.php(396): MediaWiki\ResourceLoader\FileModule->readStyleFiles(array, MediaWiki\ResourceLoader\DerivativeContext)
#12 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/Module.php(834): MediaWiki\ResourceLoader\FileModule->getStyles(MediaWiki\ResourceLoader\DerivativeContext)
#13 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/Module.php(786): MediaWiki\ResourceLoader\Module->buildContent(MediaWiki\ResourceLoader\DerivativeContext)
#14 /srv/mediawiki/php-1.40.0-wmf.12/includes/ResourceLoader/ResourceLoader.php(1109): MediaWiki\ResourceLoader\Module->getModuleContent(MediaWiki\ResourceLoader\DerivativeContext)
#15 /srv/mediawiki/php-1.40.0-wmf.12/extensions/WikimediaMaintenance/blameStartupRegistry.php(139): MediaWiki\ResourceLoader\ResourceLoader->makeModuleResponse(MediaWiki\ResourceLoader\DerivativeContext, array)
#16 /srv/mediawiki/php-1.40.0-wmf.12/maintenance/includes/MaintenanceRunner.php(309): BlameStartupRegistry->execute()
#17 /srv/mediawiki/php-1.40.0-wmf.12/maintenance/doMaintenance.php(85): MediaWiki\Maintenance\MaintenanceRunner->run()
#18 /srv/mediawiki/php-1.40.0-wmf.12/extensions/WikimediaMaintenance/blameStartupRegistry.php(336): require_once(string)
#19 /srv/mediawiki/multiversion/MWScript.php(120): require_once(string)
#20 {main}
Impact
Notes

Event Timeline

Imported in modules/PhonosButton.less:

@import 'resources/lib/ooui/wikimedia-ui-base.less';

Change 864020 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] PhonosButton.less: Change path to wikimedia-ui-base

https://gerrit.wikimedia.org/r/864020

Change 864020 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] PhonosButton.less: Change path to wikimedia-ui-base

https://gerrit.wikimedia.org/r/864020

Acceptance criteria

Once the above patch is deployed on test.wikipedia, Less_Exception_Parser: File 'resources/lib/ooui/wikimedia-ui-base.less' not found. in PhonosButton.less exceptions cease appearing in logstash.

TheresNoTime set the point value for this task to 3.Dec 5 2022, 2:19 AM

This error has not appeared in beta's logstash since ~01:36am today, where previously it had occurred 20+ times per day[1].

Phonos continues to work fine via the UI on beta, and I see no other errors in the beta logstash.

I will keep this here until it gets deployed tomorrow, so we can see if the errors stop on production.

Ref:

  1. https://beta-logs.wmcloud.org/app/dashboards#/view/default?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'2022-11-22T00:00:00.000Z',to:now))&_a=(description:'',filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'5f0c9be0-0b6f-11ec-9cde-3f4490e09a26',key:level,negate:!f,params:!(ERROR,FATAL),type:phrases,value:'ERROR,%20FATAL'),query:(bool:(minimum_should_match:1,should:!((match_phrase:(level:ERROR)),(match_phrase:(level:FATAL)))))),('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'5f0c9be0-0b6f-11ec-9cde-3f4490e09a26',key:normalized_message.keyword,negate:!f,params:(query:'%5B%7BreqId%7D%5D%20%7Bexception_url%7D%20%20%20Less_Exception_Parser:%20File%20%60resources%2Flib%2Fooui%2Fwikimedia-ui-base.less%60%20not%20found.%20in%20PhonosButton.less'),type:phrase),query:(match_phrase:(normalized_message.keyword:'%5B%7BreqId%7D%5D%20%7Bexception_url%7D%20%20%20Less_Exception_Parser:%20File%20%60resources%2Flib%2Fooui%2Fwikimedia-ui-base.less%60%20not%20found.%20in%20PhonosButton.less')))),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:'message:*Phonos*'),timeRestore:!t,title:Default,viewMode:view)

I don't think there is anything for product to look at here, so I won't put it through product sign-off.