Page MenuHomePhabricator

Clicking "Edit" on a read-only page does not load VE source code editor / does nothing
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The source editor does not open.

What should have happened instead?:

The source editor should have opened.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Firefox 109.0a1

Event Timeline

Aklapper changed the task status from Open to Stalled.Dec 4 2022, 8:35 PM

The source editor does not open.

What does happen instead?

It just stays on this page:

image.png (348×1 px, 53 KB)

Clicking "reload the page" causes it to successfully load the editor.

Tacsipacsi changed the task status from Stalled to Open.Dec 5 2022, 9:23 AM
Tacsipacsi subscribed.

Using the legacy wikitext editor (either by turning off 2017WE or by using the action=submit URL) shows the error message for the first time. I’m pretty sure Translate communicates the lack of ability to edit the page adequately (by aborting the getUserPermissionsErrorsExpensive hook), so it’s 2017WE’s fault that it doesn’t recognize it.

Screenshot 2022-12-05 at 10-22-18 View source for Manual Interface_Special pages summary_en - MediaWiki.png (525×945 px, 85 KB)

I'm able to reproduce this issue but I cannot think of anything that was changed on the Translate extension that would cause this issue.

Aklapper renamed this task from Clicking "Edit" after on the subpage of the source page language does not load the editor to Clicking "Edit" on a read-only page does not load VE source code editor / does nothing.Dec 5 2022, 9:46 AM

I'm able to reproduce this issue but I cannot think of anything that was changed on the Translate extension that would cause this issue.

Do we know it’s a regression? Since not many people use the 2017 wikitext editor, nor is it common to try to edit the /en subpages directly, I can imagine that this has always been broken, just nobody noticed it before.

I think it's related to Translate's use of the 'VisualEditorBeforeEditor' hook to disable VE on translation pages (added in March in task T174180). It looks like we're not handling this correctly on the VE side – the hook stops VE (and 2017WTE) from being loaded, but it doesn't stop us from trying to load it.

Nikerabbit changed the task status from Open to Stalled.May 22 2023, 11:43 AM
Nikerabbit moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.
Nikerabbit subscribed.

I cannot reproduced. Can someone confirm it this has been fixed in the meanwhile?

Pols12 changed the task status from Stalled to Open.May 22 2023, 8:14 PM

I can still reproduce. Please note you need to enable beta 2017 wikitext editor from Special:Preferences first.