Page MenuHomePhabricator
Create Task
Maniphest T324119

PHP Notice: Trying to access array offset on value of type null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to access array offset on value of type null
exception.trace
from /srv/mediawiki/php-1.40.0-wmf.10/extensions/GlobalBlocking/includes/GlobalBlocking.php(590)
#0 /srv/mediawiki/php-1.40.0-wmf.10/extensions/GlobalBlocking/includes/GlobalBlocking.php(590): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.10/extensions/GlobalBlocking/includes/Api/ApiGlobalBlock.php(52): MediaWiki\Extension\GlobalBlocking\GlobalBlocking::block(string, string, string, User, array)
#2 /srv/mediawiki/php-1.40.0-wmf.10/includes/api/ApiMain.php(1902): MediaWiki\Extension\GlobalBlocking\Api\ApiGlobalBlock->execute()
#3 /srv/mediawiki/php-1.40.0-wmf.10/includes/api/ApiMain.php(877): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.40.0-wmf.10/includes/api/ApiMain.php(848): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.40.0-wmf.10/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.40.0-wmf.10/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}
Impact
Notes

Seen 94 times on Nov 30 around 15:00 UTC on meta. Maybe some automated script/bot triggered this path many times.

Details

Request URL
https://meta.wikimedia.org/w/api.php
SubjectRepoBranchLines +/-
Fix PHP noticemediawiki/extensions/GlobalBlockingwmf/1.40.0-wmf.10+1 -1
Fix PHP noticemediawiki/extensions/GlobalBlockingmaster+1 -1
Fix PHP noticemediawiki/extensions/GlobalBlockingwmf/1.40.0-wmf.12+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Nov 30 2022, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2022, 3:08 PM
Daimona added subscribers: Tgr, Urbanecm.Nov 30 2022, 3:14 PM

$blockId = $status->getValue()['id']; is used before checking $status->isOK(), so it should be a simple fix. This regressed in r824578 (for T310390).

Daimona claimed this task.Nov 30 2022, 3:20 PM
gerritbot added a comment.Nov 30 2022, 3:20 PM

Change 862285 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/GlobalBlocking@master] Fix PHP notice

https://gerrit.wikimedia.org/r/862285

gerritbot added a project: Patch-For-Review.Nov 30 2022, 3:20 PM
dancy mentioned this in T320517: 1.40.0-wmf.12 deployment blockers.Nov 30 2022, 7:16 PM
gerritbot added a comment.Nov 30 2022, 7:19 PM

Change 861484 had a related patch set uploaded (by Ladsgroup; author: Daimona Eaytoy):

[mediawiki/extensions/GlobalBlocking@wmf/1.40.0-wmf.12] Fix PHP notice

https://gerrit.wikimedia.org/r/861484

gerritbot added a comment.Nov 30 2022, 7:26 PM

Change 861484 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.40.0-wmf.12] Fix PHP notice

https://gerrit.wikimedia.org/r/861484

gerritbot added a comment.Nov 30 2022, 7:27 PM

Change 861485 had a related patch set uploaded (by Ladsgroup; author: Daimona Eaytoy):

[mediawiki/extensions/GlobalBlocking@wmf/1.40.0-wmf.10] Fix PHP notice

https://gerrit.wikimedia.org/r/861485

Stashbot added a comment.Nov 30 2022, 7:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:27:57Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:861484|Fix PHP notice (T324119)]]

gerritbot added a comment.Nov 30 2022, 7:28 PM

Change 862285 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Fix PHP notice

https://gerrit.wikimedia.org/r/862285

Stashbot added a comment.Nov 30 2022, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:29:05Z] <ladsgroup@deploy1002> ladsgroup and ladsgroup: Backport for [[gerrit:861484|Fix PHP notice (T324119)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

gerritbot added a comment.Nov 30 2022, 7:29 PM

Change 861485 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.40.0-wmf.10] Fix PHP notice

https://gerrit.wikimedia.org/r/861485

Stashbot added a comment.Nov 30 2022, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:33:48Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:861484|Fix PHP notice (T324119)]] (duration: 05m 50s)

Stashbot added a comment.Nov 30 2022, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:34:26Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:861485|Fix PHP notice (T324119)]]

Stashbot added a comment.Nov 30 2022, 7:35 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:35:32Z] <ladsgroup@deploy1002> ladsgroup and ladsgroup: Backport for [[gerrit:861485|Fix PHP notice (T324119)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Nov 30 2022, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-30T19:39:58Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:861485|Fix PHP notice (T324119)]] (duration: 05m 32s)

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Nov 30 2022, 8:01 PM
dancy closed this task as Resolved.Nov 30 2022, 8:11 PM
dancy added subscribers: Ladsgroup, dancy.

The errors have gone away. Thank you @Daimona and @Ladsgroup !

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits